Problem/Motivation

Deprecation in Dart-SASS

This operation is parsed as:

    0 - ($spacer)

but you may have intended it to mean:

    0 (-($spacer))

Add a space after - to clarify that it's meant to be a binary operation, or wrap
it in parentheses to make it a unary operation. This will be an error in future
versions of Sass.

More info and automated migrator: https://sass-lang.com/d/strict-unary
   ╷
31 │         margin: 0 -($spacer);
   │                 ^^^^^^^^^^^^
   ╵

Proposed resolution

Change to @include margin(-($spacer))

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, vartheme_bs4-9.0.19

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3317526: Fixed Dart-SASS Deprecation nesting with @include margin(-($spacer)) which bring visual issues for unordered navigation list in sidebar or action tasks

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Title: Fix Dart-SASS Deprecation nesting with @include margin(-($spacer)) issue for unordered navigation list in sidebar or action tasks » Fix Dart-SASS Deprecation nesting with @include margin(-($spacer)) which bring visual issues for unordered navigation list in sidebar or action tasks

  • Rajab Natshah committed ece442b on 9.0.x
    Issue #3317526: Fix Dart-SASS Deprecation nesting with @include margin...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-9.0.0, +vartheme_bs4-9.0.19
rajab natshah’s picture

Issue summary: View changes

✅ Released vartheme_bs4-9.0.19

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.