Problem/Motivation

Forms in Drupal typically have a primary button that marks the happy flow. However the Action configuration form displays all actions with a similar weight, so the interface takes more time to scan at a glance.

Steps to reproduce

Action -> Change the author of content -> Apply to selected items

Proposed resolution

Implement a primary button in Action configuration form for consistency with other Drupal forms.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The Action configuration form implements a primary button for consistency with other Drupal forms.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3317188-2.patch759 bytesidebr
#2 3317188-2-after.png47.01 KBidebr
#2 3317188-2-before.png47.02 KBidebr
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

idebr created an issue. See original summary.

idebr’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new47.02 KB
new47.01 KB
new759 bytes

Attached patch implements a primary button in Action configuration form for consistency with other Drupal forms.

Before:

After:

dineshreddymathuku made their first commit to this issue’s fork.

graber’s picture

@idebr, you removed weight of the submit button, did you have any particular reason? This'll probably break the appearance of some action config forms as the button will not be at the bottom.

idebr’s picture

I removed the weight from the actions wrapper, since form actions are always rendered at the bottom of a form.

The weight was introduced when the element was no actions wrapper. The introduction of the actions wrapper left the weight when it could have been removed in #3311031: Form actions should be of type actions

graber’s picture

Status: Needs review » Fixed

Ahh, good to know, thanks :)

  • Graber committed f686ce8 on 4.2.x
    Issue #3317188 by idebr: Implement a primary button in Action...
graber’s picture

We could've removed the above comment as well..

  • Graber committed f790e3c on 4.2.x
    Issue #3317188: Removed no longer applicable comment.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.