Problem/Motivation

The base obfuscate_module depends on the rot13 sub-module. This makes no sense at all, since that means that under no circumstance is it possible to enable the module without enabling the sub-module.

Steps to reproduce

Enable the module. See that the rot13 is also enabled at the same time.

Proposed resolution

Integrate the sub-module with the main module.

Remaining tasks

  • Move the modules/rot13/src/Twig folder to src
  • Fix the namespace of src/Twig/Rot13Extension.php to be namespace Drupal\obfuscate_email\Twig;
  • Rename the modules/rot13/rot13.services.yml to be obfuscate_email.services.yml
  • Fix the class property in obfuscate_email.services.yml to be Drupal\obfuscate_email\Twig\Rot13Extension
  • Create a obfuscate_email.install file with an update_hook() function that disables the rot13 module
  • Remove the dependency on rot13 from obfuscate_email.info.yml

User interface changes

None

API changes

Namespace of the Twig extension class is changed.

Data model changes

None

Comments

jcnventura created an issue. See original summary.

b_sharpe’s picture

I'd agree, I believe the original module had aspirations of multi-functional uses of the submodule. I plan on starting 2.x branch here to get into better semver and prep for d10 hopefully in the next week or two, and will add this to the list of inital refactor.

jcnventura’s picture

Yes, that's the other option.. Go and start a new drupal module called rot13 and move all the sub-module code to that module. However, I'd rather that the sub-module is assimilated into the main module.

b_sharpe’s picture

Version: 8.x-1.x-dev » 2.0.x-dev

Yes, that would be the intention is to merge into the main module.

  • b_sharpe committed b0bb597 on 2.0.x
    Issue #3314887 by b_sharpe: rot13 sub-module makes no sense, please...
b_sharpe’s picture

Status: Active » Fixed

Done in 2.x

  • b_sharpe committed 5d802c6 on 2.0.x
    Issue #3314887 by b_sharpe: code cleanup post-move of rot13.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.