Problem/Motivation

The options under "Settings" tab to adjust responsive behavior don't work.

Steps to reproduce

  1. Open Layout builder
  2. Add EBT Slick slider
  3. Add some slides
  4. Go to Settings preferences
  5. Customize "Slides to show" or "Slides To Scroll"

Current result: no responsive settings are applied to the slider.
Expected result: slider adjsut slide visibility based on different breakpoints

Proposed resolution

Update logic to add selected settings on slick API

CommentFileSizeAuthor
#2 ebt_slick_slider-3314558-2.patch6.45 KBgerzenstl

Comments

gerzenstl created an issue. See original summary.

gerzenstl’s picture

gerzenstl commented
StatusFileSize
new ebt_slick_slider-3314558-2.patch6.45 KB
gerzenstl’s picture

gerzenstl commented
Status: Active » Needs review

  • levmyshkin committed a8ddc90 on 1.4.x 
    Issue #3314558 by gerzenstl: Responsive options not working

  • levmyshkin committed 0045c38 on 1.3.x 
    Issue #3314558 by gerzenstl: Responsive options not working
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented

Hi gerzenstl, thank you for the patch! I applied, tested it and released new 1.3.2 version for Drupal 8 and 1.4.0 for Drupal 9.

I didn't apply "infinite: false" setting, but I think you can use common infinite checkbox to make it non infinite. I can add infinite settins for each breakpoint, but then it will be needed to check "infinite" checkbox for all breakpoints do not overide common infinite checkbox. Feel free to open new ticket for it, if you need it.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Fixed
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)