Problem/Motivation

Undefined array key "children" field_group.features.inc:35                     [warning]
WD php: TypeError: in_array(): Argument #2 ($haystack) must be of type array,  [error]
null given in in_array() (line 35 of field_group/field_group.features.inc).
TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() (line 35 of field_group/field_group.features.inc).

Steps to reproduce

Proposed resolution

Check if the children key isset or continue.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3314247-2-field-group-children.patch835 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Component: Miscellaneous » Code
StatusFileSize
new 3314247-2-field-group-children.patch835 bytes
alexanderj’s picture

alexanderj commented
Assigned: Unassigned » alexanderj

I will review it.

alexanderj’s picture

alexanderj commented
Assigned: alexanderj » Unassigned

The changes look good to me. The error stopped appearing after using the patch.
+1 for RTBC.

christyanpaim’s picture

christyanpaim commented
Assigned: Unassigned » christyanpaim
christyanpaim’s picture

christyanpaim commented
Assigned: christyanpaim » Unassigned

Works fine to me!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@alexanderj and @christyanpaim could one of you change the status of the issue to "Reviewed and Tested by the Community"? That would help the maintainers know it's ready for commit. (I shouldn't because I posted the patch)

christyanpaim’s picture

christyanpaim commented
Status: Needs review » Reviewed & tested by the community

  • swentel committed b606ed0 on 7.x-1.x 
    Issue #3314247 by joelpittet: TypeError: in_array(): Argument #2 ($...
swentel’s picture

swentel commented
Status: Reviewed & tested by the community » Fixed

committed and pushed, will trigger a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.