We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

CommentFileSizeAuthor
#15 README.md1.93 KBdineshreddymathuku
#12 3313934-12.patch4.36 KBlbonfioli
#8 3313934-8.patch2.16 KBlbonfioli

Issue fork admin_toolbar-3313934

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Manoj Raj.R created an issue. See original summary.

Manoj Raj.R opened merge request !35

Manoj Raj.R opened merge request !36

Manoj Raj.R closed merge request !36

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Active » Needs review

Committed in accordance to the stated requirement.
Ignoring the #2 and #3 it happened on put correct commit on #4 with merge request as to Pass the Build.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

There needs to be more work done on the README file beyond changing its filename.

lbonfioli’s picture

lbonfioli commented
Assigned: Unassigned » lbonfioli

I'll provide the conversion

lbonfioli’s picture

lbonfioli commented
StatusFileSize
new 3313934-8.patch2.16 KB

Here is a patch with the conversion to .md

lbonfioli’s picture

lbonfioli commented
Status: Needs work » Needs review
lbonfioli’s picture

lbonfioli commented
Assigned: lbonfioli » Unassigned
LeoAlcci’s picture

LeoAlcci commented
Status: Needs review » Needs work

I think you just delete the file? maybe you made a mistake?

lbonfioli’s picture

lbonfioli commented
StatusFileSize
new 3313934-12.patch4.36 KB

Here is an updated patch, thanks.

lbonfioli’s picture

lbonfioli commented
Status: Needs work » Needs review
dineshreddymathuku’s picture

dineshreddymathuku commented

As per Markdown format will update

dineshreddymathuku’s picture

dineshreddymathuku commented
StatusFileSize
new README.md1.93 KB
dineshreddymathuku’s picture

dineshreddymathuku commented

Hi @lbonfioli you provided patch misplaced, so i updated the file and created new merge
please check and review it once
thanks

lbonfioli’s picture

lbonfioli commented
Assigned: Unassigned » lbonfioli
lbonfioli’s picture

lbonfioli commented
Status: Needs review » Reviewed & tested by the community

The file was correctly formated in .md. Moving to RTBC.

lbonfioli’s picture

lbonfioli commented
Assigned: lbonfioli » Unassigned

romainj made their first commit to this issue’s fork.

  • romainj committed a466bda on 3.x authored by Manoj Raj.R 
    Issue #3313934 by Manoj Raj.R, lbonfioli, dineshreddymathuku: Replace...
romainj’s picture

romainj commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

romainj’s picture

romainj commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.