Problem/Motivation

CKEditor 4 is going away. See https://www.drupal.org/node/3304481.

All contributed modules need to transition to supporting CKEditor 5.

Steps to reproduce

Proposed resolution

Use the official CKEditor 5 equivalent plugin: https://ckeditor.com/docs/ckeditor5/latest/features/find-and-replace.html

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 ck5-find-default.png383.69 KBfathershawn
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Wim Leers created an issue. See original summary.

FatherShawn made their first commit to this issue’s fork.

fathershawn’s picture

Assigned: Unassigned » fathershawn

fathershawn’s picture

Manually tested in a clean install of D10.0 and added a FunctionalJavascript test as well. I haven't tested the CKEditor 4 => 5 migration plugin yet. That's next.

fathershawn’s picture

Title: CKEditor 5 compatibility » CKEditor 5/D10 compatibility
fathershawn’s picture

Status: Active » Needs review
fathershawn’s picture

fathershawn’s picture

I'll open a 2.x branch since the D10 version is only CKE 5 compatible and leave the prior code in place

fathershawn’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Reviewed & tested by the community

  • FatherShawn committed 8c6d849e on 2.0.x
    Issue #3312842 by FatherShawn: CKEditor 5 compatibility
    - Working...
fathershawn’s picture

I've made a 2.0.0@beta release. Even though there is test coverage, I'd like some reports from the wild before I mark it stable.

solideogloria’s picture

Status: Reviewed & tested by the community » Fixed

I think this should be "Fixed", since a commit was made.

fathershawn’s picture

Status: Fixed » Reviewed & tested by the community

Fixed is going to automatically move to "Closed (fixed)" after a time, and I have this issue still open intentionally pending reports of success on the 2.x branch from others. See the note in the D10 section of the project page.

solideogloria’s picture

It works for me with CKEditor 5 on Drupal 9.5. I didn't migrate my settings, so I didn't test that.

However, I did encounter a couple usability issues.

  1. The Find/Replace dialog can't be dragged, and so there are sometimes words that are "found" but I can't see them because they are behind the dialog.
  2. It's annoying that I have to click "Find" before I can enter text in the "Replace" textbox or click to "Replace" or "Replace All". I don't know of a single Find/Replace implementation in any app that works like that. It's tedious and too many clicks and arbitrary restrictions.

Let me know if they need to be put in new issues.

fathershawn’s picture

Thanks for the report. All the behaviors of the provided feature should be coming from CKEditor - I'm simply loading their package. The next step is to get a instance loaded outside of Drupal and see if it's the same interaction.

fathershawn’s picture

StatusFileSize
new383.69 KB

Confirmed this as the default behavior. You can also download a default at the online builder.
default find/replace screenshot

solideogloria’s picture

Looks like one of my complaints already has a GitHub issue open:

Search panel from Find and replace plugin should be movable

fathershawn’s picture

fathershawn’s picture

wim leers’s picture

Status: Reviewed & tested by the community » Fixed
fathershawn’s picture

Sure 😀 It's been out long enough without reports. I'll update the README and tag it stable. Thanks for the help Wim!

fathershawn’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.