Problem/Motivation
CKEditor 4 is going away. See https://www.drupal.org/node/3304481.
All contributed modules need to transition to supporting CKEditor 5.
Steps to reproduce
Proposed resolution
Use the official CKEditor 5 equivalent plugin: https://ckeditor.com/docs/ckeditor5/latest/features/find-and-replace.html
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | ck5-find-default.png | 383.69 KB | fathershawn |
Issue fork ckeditor_find-3312842
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2.0.x
compare
- 3312842-ckeditor-5-compatibility
changes, plain diff MR !3
Comments
Comment #3
fathershawnComment #5
fathershawnManually tested in a clean install of D10.0 and added a FunctionalJavascript test as well. I haven't tested the CKEditor 4 => 5 migration plugin yet. That's next.
Comment #6
fathershawnComment #7
fathershawnComment #8
fathershawnComment #9
fathershawnI'll open a 2.x branch since the D10 version is only CKE 5 compatible and leave the prior code in place
Comment #10
fathershawnComment #12
fathershawnI've made a 2.0.0@beta release. Even though there is test coverage, I'd like some reports from the wild before I mark it stable.
Comment #14
solideogloria commentedI think this should be "Fixed", since a commit was made.
Comment #15
fathershawnFixed is going to automatically move to "Closed (fixed)" after a time, and I have this issue still open intentionally pending reports of success on the 2.x branch from others. See the note in the D10 section of the project page.
Comment #16
solideogloria commentedIt works for me with CKEditor 5 on Drupal 9.5. I didn't migrate my settings, so I didn't test that.
However, I did encounter a couple usability issues.
Let me know if they need to be put in new issues.
Comment #17
fathershawnThanks for the report. All the behaviors of the provided feature should be coming from CKEditor - I'm simply loading their package. The next step is to get a instance loaded outside of Drupal and see if it's the same interaction.
Comment #18
fathershawnConfirmed this as the default behavior. You can also download a default at the online builder.

Comment #19
solideogloria commentedLooks like one of my complaints already has a GitHub issue open:
Search panel from Find and replace plugin should be movable
Comment #20
fathershawnComment #21
solideogloria commentedHere's the other:
Find & Replace: Always allow entering replacement text. Don't require Find prior to Replace.
Comment #22
fathershawnComment #23
wim leersAFAICT based on https://www.drupal.org/project/ckeditor_find/releases/2.0.0-beta1, this can be considered ?
Updated https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckedito... too 👍
Comment #24
fathershawnSure 😀 It's been out long enough without reports. I'll update the README and tag it stable. Thanks for the help Wim!
Comment #25
fathershawn