Problem/Motivation

Drupal 10 compatibility Issues

Steps to reproduce

1. Install the acquia_claro theme on a Drupal website.
2. Run the update scan with the Upgrade Status Drupal module.
3. Notice all the issues mentioned by Upgrade Status to make the theme compatible.
(Attached is the HTML file of the issues reported)

Proposed resolution

1. Fix the issues and scan the theme again.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 Screenshot 2022-10-06 at 1.36.05 PM.png61.92 KBankitv18
#8 Screenshot 2022-10-06 at 1.35.11 PM.png283.06 KBankitv18
#3 single-export-acquia_claro-2022-09-29T10_00_20+0000 (1).txt988 bytespanshulk
#2 3312550.patch402 bytesanchal_gupta
single-export-acquia_claro-2022-09-29T10_00_20+0000.txt4.04 KBpanshulk

Issue fork acquia_claro-3312550

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

panshulk created an issue. See original summary.

anchal_gupta’s picture

anchal_gupta commented
StatusFileSize
new 3312550.patch402 bytes

I have uploaded the patch. Please review it

panshulk’s picture

panshulk commented
StatusFileSize
new single-export-acquia_claro-2022-09-29T10_00_20+0000 (1).txt988 bytes

panshulk opened merge request !1

panshulk’s picture

panshulk commented

Updated the merge request with required changes - https://git.drupalcode.org/project/acquia_claro/-/merge_requests/1
Marking it as "Needs Review".

panshulk’s picture

panshulk commented
Assigned: panshulk » Unassigned
Status: Active » Needs review
ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18
ankitv18’s picture

ankitv18 commented
StatusFileSize
new Screenshot 2022-10-06 at 1.35.11 PM.png283.06 KB
new Screenshot 2022-10-06 at 1.36.05 PM.png61.92 KB

Test and reviewed the changes made in https://git.drupalcode.org/project/acquia_claro/-/merge_requests/1.patch (MR#1)
Attaching the screenshots.

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community
ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

MR looks good!

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Version: 1.3.3 » 1.3.x-dev
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

vishalkhode made their first commit to this issue’s fork.

  • vishalkhode committed a79a235 on 1.3.x 
    Issue #3312550: Fix deprecated warning & color module dependency issue.
vishalkhode’s picture

vishalkhode commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone for working on this. Changes merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.