Problem/Motivation

The 1.x branch has removed hal_post_update_delete_settings, this means that if someone updates from 8.9 to 9.4 + contrib HAL, they'll miss the update and get 

The installed version of the /HAL/ module is too old to update. Update to a
version prior to 10.0.0 first (missing updates:
hal_post_update_delete_settings)

(also as you can see the version is incorrect in the hook_removed_post_updates() definition).

Steps to reproduce

Proposed resolution

Add back the post update in the 1.x branch, probably.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork hal-3312340

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: 1.x branch removes » 1.x branch removes hal_post_update_delete_settings()
catch’s picture

catch
he/him
Primary language English
commented

See Slack discussion https://drupal.slack.com/archives/C014CT1CN1M/p1664373666318009

fathima.asmat’s picture

fathima.asmat commented

The workaround steps ( suggested by @catch) to get around this temporarily:

  1. Remove contrib HAL i.e if an upgraded dependency package already relies on contrib HAL, composer remove will not let you do it, so manually remove contrib HAL module folder/files.
  2. Update from Drupal 8.x to 9.4 - run updb, etc.
  3. Add contrib HAL module back

Spokje made their first commit to this issue’s fork.

Spokje opened merge request !1

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
fathima.asmat’s picture

fathima.asmat commented

That MR#1 from Spokje is working perfectly and the issue with 'updb' no longer appears on V1.0.2. Happy to mark it as RTBC :)

fathima.asmat’s picture

fathima.asmat commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented

The commit on the MR looks fine, but the actual MR diff looks like it has a lot of unrelated changes - maybe the target branch change?

spokje’s picture

spokje
Primary language Dutch
commented

Both

https://git.drupalcode.org/project/hal/-/merge_requests/1/diffs
and
https://git.drupalcode.org/project/hal/-/merge_requests/1.diff

look fine down here?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I don't recall deleting this so does that mean there are other things that changed in the core version after the subtree split?

catch’s picture

catch
he/him
Primary language English
commented

@larowlan I don't think it changed in core 9.5.x at all, is it possible the 10.x subtree split has bled into the 1.x branch?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Very possible, regardless I'll fix this and cut a release

  • larowlan committed 00218c8 on 1.x authored by Spokje 
    Issue #3312340 by Spokje, catch, fathima.asmat: 1.x branch removes...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

tagging 1.0.3, thanks all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.