Problem/Motivation

In #3301795: Add support for Brightcove videos support for Brightcove was added, however, it appears that the regular expression to match the Brightcove URL might be a little too restrictive/presumptious.

According to https://studio.support.brightcove.com/publish/choosing-correct-embed-code.html not all URLs contain 'default_default' which is part of what the regular expression matches, rather the first 'default' could be alphanumeric or could contain dashes, such as;

rf1BTdKk6M_default
or
a4d923de-cccc-4a40-9756-31e8368d530d_default

So the regular expression should probably be updated to support this format too.

Steps to reproduce

Attempt to add the following video: https://players.brightcove.net/1507807800001/rf1BTdKk6M_default/index.ht...

Proposed resolution

Update the regular expression to not hardcode 'default_default'.

Remaining tasks

Add patch

User interface changes

None

API changes

None

Data model changes

None

Issue fork media_remote-3312167

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

owenbush created an issue. See original summary.

owenbush opened merge request !10

owenbush’s picture

owenbush commented
Status: Active » Needs review

Ready for review.

marcoscano made their first commit to this issue’s fork.

  • marcoscano committed 5b974d3 on 1.x authored by owenbush 
    Issue #3312167 by owenbush, marcoscano: Brightcove Regular Expression...
marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Needs review » Fixed

Thanks for contributing! This looks good, merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.