Problem/Motivation

Cancellation of the warmer cron:
Error: Call to a member function accessCheck() on array in Drupal\warmer_entity\Plugin\warmer\EntityWarmer->loadMultiple() (line 96 of /web/modules/contrib/warmer/modules/warmer_entity/src/Plugin/warmer/EntityWarmer.php)

Drupal 9.4.5
PHP: 8.1

Issue fork warmer-3309435

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Frank.dev created an issue. See original summary.

lhridley made their first commit to this issue’s fork.

lisa.rae’s picture

lisa.rae commented
Assigned: Unassigned » lisa.rae
lisa.rae’s picture

lisa.rae commented
Related issues: +#3309120: Drupal 10 Compatibility Fixes

lhridley opened merge request !8

lisa.rae’s picture

lisa.rae commented
Status: Active » Needs review
lisa.rae’s picture

lisa.rae commented
Version: 2.0.6 » 2.x-dev
Assigned: lisa.rae » Unassigned
Priority: Normal » Major
frank.dev’s picture

frank.dev commented

Note - because "Needs review" for 2.x-dev:
The above error also exists (currently) for the this version.

lisa.rae’s picture

lisa.rae commented

Last revision to MR expands test coverage to execute queued items via cron after creation, to capture regressions that result in failed queue execution.

frank.dev’s picture

frank.dev commented

OK, got it. :-)

lisa.rae’s picture

lisa.rae commented

Frank.dev Since you reported this bug, I've submitted the patch to fix it and added test coverage, but I'm not the maintainer, we'll have to wait for e0ips0 to accept the MR and merge it, and release a new release version.

In the meantime, if you want to apply the patch with composer and test it, then confirm back that the bug has been fixed, that would be great! All patches typically go through a community peer review process before they are merged into the module.

Have a great day!

frank.dev’s picture

frank.dev commented

I'm happy to try that.
Can you please offer me a link to the patch?
(Maybe I'm just blind, but I can't find him here.)

juanjol’s picture

juanjol
Primary language Spanish
commented
Status: Needs review » Needs work

I've tested the MR and it seems to work correctly, can we probably mark it as RTBC?
To get the patch what I have done is to go to drupalcode.org and in the "Code" drop down button, select "Plain diff". I don't know if there is a more efficient way.

juanjol’s picture

juanjol
Primary language Spanish
commented
Status: Needs work » Needs review

Sorry, I changed the status by mistake. I leave it as Needs review again.

lisa.rae’s picture

lisa.rae commented

Sure thing, Frank.dev! Drupal.org changed the patch process after migrating to Gitlab for code repo hosting, the preferred way to to submit changes to core and contrib is to create a fork of the project, work on your code changes and generate a merge request.

To generate a patch from the MR, you can click the link to the MR (see above or here), and add either .patch or .diff to the end of the URL, this will generate a patch URL that can then be used by Composer to add the patch (you will need to have composer/patches installed for the patch to be applied during composer install or composer update).

Reference: https://stackoverflow.com/questions/38203139/creating-patch-from-merge-r...

e0ipso made their first commit to this issue’s fork.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Thanks all. Merging.

  • e0ipso committed d9e33a1 on 2.x authored by lhridley 
    Issue #3309435 by lhridley, Frank.dev, e0ipso, Juanjol: Error: Call to a...
lisa.rae’s picture

lisa.rae commented

@e0ipso -- just a comment regarding classy vs claro -- note that the Classy theme is deprecated and will be removed in Drupal 10, which I why I switched the testing theme to Claro.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.