Problem/Motivation

Speed up testbot and simplify tests by using the testing profile instead of the standard profile.

Steps to reproduce

Proposed resolution

Convert Drupal\Tests\content_translation\Functional\ContentTranslationMetadataFieldsTest to use the testing profile, not the standard profile.

Remaining tasks

Update patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3308928-2.patch992 bytessmustgrave

Issue fork drupal-3308928

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
StatusFileSize
new 3308928-2.patch992 bytes

Adding olivero_test to install the article content type by default.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Why do we need olivero_test? Can we just create the article content type?

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

Postponing until https://www.drupal.org/project/drupal/issues/2254189 is in. I'm adding a test module to add an article, fields, etc.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave
Status: Postponed » Needs work

Learned more since last year so will pick this back up.

smustgrave opened merge request !5598

smustgrave’s picture

smustgrave commented
Assigned: smustgrave » Unassigned
Status: Needs work » Needs review

Was easier then I thought.

smustgrave’s picture

smustgrave commented
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

I have questions about issue scoping, this is a super simple and small change, but similar issues have been committed already, setting this to rtbc based on those

  • catch committed b229d92c on 11.x 
    Issue #3308928 by smustgrave, longwave, borisson_: Fix test performance...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Yes it's tempting to ask for a wider scope, but I think we did all the 1-1 (at the time) changes in one go originally and are left with tests that need small modifications in order to use testing profile, so it is probably fine.

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

  • catch committed 1b81796a on 10.2.x 
    Issue #3308928 by smustgrave, longwave, borisson_: Fix test performance...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.