FILE: /home/drupal/myproject/magnific_popup/src/Plugin/Field/FieldFormatter/VideoEmbedField.php
---------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------
163 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
175 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------
FILE: /home/drupal/myproject/magnific_popup/src/Plugin/Field/FieldFormatter/MagnificPopup.php
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------
105 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------
FILE: /home/drupal/myproject/magnific_popup/js/magnific-popup.js
---------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
14 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
27 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
27 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
---------------------------------------------------------------------------------
FILE: /home/drupal/myproject/magnific_popup/js/magnific-popup.video-embed.js
---------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------
13 | ERROR | [x] Expected 1 space before "+"; 0 found
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
37 | ERROR | [x] Expected 1 space before "+"; 0 found
---------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | drupal-coding-standard-issues-3308509-10.patch | 7.16 KB | LeoAlcci |
| #6 | drupal-coding-standard-issues-3308509-6.patch | 4.91 KB | cinarb |
| #3 | drupal-coding-standard-issues-3308509-1.patch | 4.91 KB | dharti patel |
Issue fork magnific_popup-3308509
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
dharti patel commentedHello,
I have created a patch to fix this issue.
Kindly review the patch.
Thanks!
Comment #5
cinarb commentedHi ill review this
Comment #6
cinarb commentedHi @Dharti Patel, Your patch was applied cleanly. Most of the issues are fixed, just one thing. On line 104 the load function was missing. I just updated the patch with this bit of change.
Comment #7
LeoAlcci commentedI will review it!
Comment #8
LeoAlcci commentedComment #9
LeoAlcci commentedThanks for the contribution, I found the DI wasnt working. So I fixed it! Please kindly review it!
Comment #10
LeoAlcci commentedIgnore the patch above I found an issue, this is the one.
Comment #11
LeoAlcci commented..
Comment #12
LeoAlcci commentedComment #13
WagnerMelo commentedHi, i'll review it. XD
Comment #14
WagnerMelo commentedI reviewed the patch sended in #10, and all errors are solved.
So i'll move this issue to RTBC.