FILE: /home/drupal/myproject/magnific_popup/src/Plugin/Field/FieldFormatter/VideoEmbedField.php
---------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------
 163 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
 175 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------

FILE: /home/drupal/myproject/magnific_popup/src/Plugin/Field/FieldFormatter/MagnificPopup.php
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------
 105 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------

FILE: /home/drupal/myproject/magnific_popup/js/magnific-popup.js
---------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------
  8 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
  9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 14 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 27 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 27 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
---------------------------------------------------------------------------------

FILE: /home/drupal/myproject/magnific_popup/js/magnific-popup.video-embed.js
---------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------
 13 | ERROR | [x] Expected 1 space before "+"; 0 found
 22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 37 | ERROR | [x] Expected 1 space before "+"; 0 found
---------------------------------------------------------------------------------
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Dharti Patel created an issue. See original summary.

mahtab_alam made their first commit to this issue’s fork.

dharti patel’s picture

Assigned: dharti patel » Unassigned
Status: Active » Needs review
StatusFileSize
new4.91 KB

Hello,
I have created a patch to fix this issue.
Kindly review the patch.

Thanks!

cinarb’s picture

Assigned: Unassigned » cinarb

Hi ill review this

cinarb’s picture

Assigned: cinarb » Unassigned
StatusFileSize
new4.91 KB

Hi @Dharti Patel, Your patch was applied cleanly. Most of the issues are fixed, just one thing. On line 104 the load function was missing. I just updated the patch with this bit of change.

LeoAlcci’s picture

I will review it!

LeoAlcci’s picture

Assigned: Unassigned » LeoAlcci
LeoAlcci’s picture

Thanks for the contribution, I found the DI wasnt working. So I fixed it! Please kindly review it!

LeoAlcci’s picture

Ignore the patch above I found an issue, this is the one.

LeoAlcci’s picture

Assigned: LeoAlcci » Unassigned

..

LeoAlcci’s picture

WagnerMelo’s picture

Assigned: Unassigned » WagnerMelo

Hi, i'll review it. XD

WagnerMelo’s picture

Assigned: WagnerMelo » Unassigned
Status: Needs review » Reviewed & tested by the community

I reviewed the patch sended in #10, and all errors are solved.
So i'll move this issue to RTBC.