Problem/Motivation

When you try to edit an existing tag, the autocomplete is not returning any results, so it is not working as it should.

Steps to reproduce

Try to edit one of the existing tag, the autocomplete shouldn't return any results.

Proposed resolution

We are going to handle the tag edit from the tagify.js, using the event edit:input coming from Tagify component.

See the Tagify component event over here: https://github.com/yairEO/tagify#events

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 tagify-3307339-5.patch595 bytesreenaraghavan
#5 Screenshot from 2022-09-02 00-10-49.png20.38 KBreenaraghavan
#5 Screenshot from 2022-09-02 00-10-20.png20.31 KBreenaraghavan

Issue fork tagify-3307339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gxleano created an issue. See original summary.

gxleano’s picture

gxleano commented
Status: Active » Needs review

gxleano opened merge request !11

reenaraghavan’s picture

reenaraghavan commented
Assigned: Unassigned » reenaraghavan

I will review this.

reenaraghavan’s picture

reenaraghavan commented
Assigned: reenaraghavan » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2022-09-02 00-10-20.png20.31 KB
new Screenshot from 2022-09-02 00-10-49.png20.38 KB
new tagify-3307339-5.patch595 bytes

I have tested this.
Step followed =>
Edited an existing tag.
The autocomplete is returning results, so it is working as it should.
Attached the screenshots of Before editing the tag and after editing the tag.

Also attaching the patch created using rector.

gxleano’s picture

gxleano commented
Status: Reviewed & tested by the community » Fixed

Thanks @reenaraghavan for review!

  • gxleano committed 4776a7c on 1.0.x 
    Issue #3307339: Fix tag editing functionality
gxleano’s picture

gxleano commented
Status: Fixed » Closed (fixed)

Added to the 1.0.8 release.