Payload error [#3306168]

Problem/Motivation

After disabling DANSE log -module got these errors and white screen on /admin/reports/danse

Error: Class "Drupal\danse_log\Payload" not found in Drupal\danse\PayloadBase::fromArray() (line 18 of /var/www/html/site/web/modules/contrib/danse/src/PayloadBase.php)
#0 /var/www/html/site/web/modules/contrib/danse/src/Entity/Event.php(86): Drupal\danse\PayloadBase::fromArray()
#1 /var/www/html/site/web/modules/contrib/danse/src/Plugin/views/field/EventLabel.php(20): Drupal\danse\Entity\Event->getPayload()...

Steps to reproduce

Enable

1. DANSE Content, danse Log, danse user and the main module.
2. Not sure is this needed, Add to default comments create event: create, publish
3. access to /admin/reports/danse and it is showing log events
4. Uninstall danse log -module
5. clear caches, and try to access to /admin/reports/danse - does not work

ALSO, if running "drush cron" gives error:

TypeError: Drupal\danse\PluginBase::subscriptionKey(): Argument #2 must be of type string, null given, called in /var/www/html/site/web/modules/contrib/danse/modules/content/src/Payload.php on line 68 in Drupal\danse\PluginBase->subscriptionKey() (line 231 of /var/www/html/site/web/modules/contrib/danse/src/PluginBase.php) #0 /var/www/html/site/web/modules/contrib/danse/modules/content/src/Payload.php(68): Drupal\danse\PluginBase->subscriptionKey()

Tried to fix the situation:
1. Enabled the module Danse Log again, and the /admin/reports/danse started to work.
But the site cron is not running, running cron gives the same error message as mentioned above and white screen, so the site is unusable.
2. Uninstalled all Danse modules and the main module, and cron is able to run again

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork danse-3306168

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3306168-payload-error

changes, plain diff MR !2

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 August 2022 at 09:30

Youcanlearnit created an issue. See original summary.

Comment #2

Youcanlearnit commented 26 August 2022 at 09:33

Issue summary:

View changes

Comment #3

Youcanlearnit commented 26 August 2022 at 09:35

Issue summary:

View changes

Comment #4

Youcanlearnit commented 26 August 2022 at 09:40

Issue summary:

View changes

Comment #5

jurgenhaas

he/him

German

Gottmadingen

commented 26 August 2022 at 15:01

Hmm, OK that sounds as if there are events and notification entities left behind that belong to the log module and since that's gone, the error may be explainable.

To prevent that from happening, we could potentially delete all log module related events and notifications. On the other hand, there could be so many of them, that this could easily run into a time-out which will cause even more potential damage.

This is one more of those examples, why I think, uninstalling modules is just a bad idea. There should be some guidelines that explain, that testing modules should be done in a development environment, where all this doesn't matter. There, you could always roll back to a previous state when restoring a db backup.

We can instead try and catch the exception so that at least the site would continue to work in such a scenario.