Problem/Motivation

For block config form inside Options the "Number of tweets to display" field's value always shows the default value, Not the value that we enter and save the block.

Steps to reproduce

Place the "twitter search" block in any region and change the value of the field to "Number of tweets to display" to something else (2, 4 ... anything) but not 3. and save the block, edit the block again and you will still see the field's value 3.

Proposed resolution

Use the correct key to render already saved value.

CommentFileSizeAuthor
Screenshot 2022-08-25 at 8.50.24 PM.png262.81 KBmiteshmap

Issue fork twitter_api_block-3306083

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    1 hidden branch
  • 4.0.x Comparechanges, plain diff MR !7
About issue forks

Comments

miteshmap created an issue. See original summary.

miteshmap opened merge request !7

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Active » Needs review

PR is ready for review and merge

matthieuscarset made their first commit to this issue’s fork.

matthieuscarset closed merge request !7

matthieuscarset’s picture

matthieuscarset commented
Status: Needs review » Fixed

Thank you very much for reporting this issue and for the MR.

It's fixed on 4.0.x branch.

Will be shipped in next release.

miteshmap’s picture

miteshmap
Primary language Gujarati
commented

Thanks @matthieuscarset for the quick merge :-)

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
Status: Fixed » Needs work

I installed this module and had the issue outlined here. I applied the patch and found that it did resolve the issue of the number not saving in the admin UI. However, it doesn't increase the number of tweets in the block. I updated it a number of time and cleared cache to verify it wasn't a local issue.

Moving this back to Needs Work for further review.

matthieuscarset’s picture

matthieuscarset commented
Status: Needs work » Fixed

This issue has been fixed in 4.0.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.