Problem/Motivation

The value of margin-bottom for node__meta class is missing the unit.

Steps to reproduce

Given that Vartheme is enabled
When authoring information with node__meta class exists
Then it will have invalid margin-bottom value.

Deprecation Warning 
This operation is parsed as:

    0 - ($spacer)

but you may have intended it to mean:

    0 (-($spacer))

Add a space after - to clarify that it's meant to be a binary operation, or wrap
it in parentheses to make it a unary operation. This will be an error in future
versions of Sass.

More info and automated migrator: https://sass-lang.com/d/strict-unary
   ╷
31 │         margin: 0 -($spacer);
   │                 ^^^^^^^^^^^^
   ╵

Proposed resolution

Add rem unit to the value.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, vartheme_bs4-9.0.18

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

CommentFileSizeAuthor
#6 3305949-6.patch3.5 KBrajab natshah
#2 3305949.patch1.27 KBredwan jamous

Comments

RedwanJamous created an issue. See original summary.

redwan jamous’s picture

StatusFileSize
new1.27 KB
redwan jamous’s picture

Issue summary: View changes
Status: Active » Needs review
redwan jamous’s picture

rajab natshah’s picture

Title: Invalid margin-bottom value for node__meta class » Fix invalid margin-bottom value for node__meta class
rajab natshah’s picture

StatusFileSize
new3.5 KB

  • Rajab Natshah committed b902b24 on 9.0.x
    Issue #3305949 by RedwanJamous: Fix invalid margin-bottom value for...
rajab natshah’s picture

Committed with

git commit -m 'Issue #3305949 by RedwanJamous: Fix invalid margin-bottom value for node__meta class' --author="Redwan Jamous <59582-RedwanJamous@users.noreply.drupalcode.org>"

Not sure why the --author did not set for this commit.

rajab natshah’s picture

rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

✅ Released vartheme_bs4-9.0.18

rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.