Problem/Motivation
The value of margin-bottom for node__meta class is missing the unit.
Steps to reproduce
Given that Vartheme is enabled
When authoring information with node__meta class exists
Then it will have invalid margin-bottom value.
Deprecation Warning
This operation is parsed as:
0 - ($spacer)
but you may have intended it to mean:
0 (-($spacer))
Add a space after - to clarify that it's meant to be a binary operation, or wrap
it in parentheses to make it a unary operation. This will be an error in future
versions of Sass.
More info and automated migrator: https://sass-lang.com/d/strict-unary
╷
31 │ margin: 0 -($spacer);
│ ^^^^^^^^^^^^
╵
Proposed resolution
Add rem unit to the value.
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release Varbase 9.0.9, vartheme_bs4-9.0.18
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3305949 by RedwanJamous: Fixed invalid
margin-bottomvalue fornode__metaclass
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3305949-6.patch | 3.5 KB | rajab natshah |
| #2 | 3305949.patch | 1.27 KB | redwan jamous |
Comments
Comment #2
redwan jamous commentedComment #3
redwan jamous commentedComment #4
redwan jamous commentedComment #5
rajab natshahComment #6
rajab natshahComment #8
rajab natshahCommitted with
Not sure why the --author did not set for this commit.
Comment #9
rajab natshahBarrio is having a related issue
#3315648: Deprecation warning in sidebar.scss
Comment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #13
rajab natshah#3317380: Update Nodejs packages to match with latest Drupal core for compiling and linting
To follow up with fixes on more issues of deprecations
Comment #14
rajab natshah✅ Released vartheme_bs4-9.0.18
Comment #15
rajab natshah#3315648: Deprecation warning in sidebar.scss
Comment #16
rajab natshah✅ Released Varbase 9.0.9