When placing a breadcrumb block in a way that it is also rendered in a layout builder preview, it seems to be using the path of the layout builder page to generate the breadcrumb trail.

In my specific case I am adding the system breadcrumbs to a node template with {{ drupal_block('system_breadcrumb_block') }}

And it is rendering the breadcrumb like this: Node > [current_node:label] > [current_node:label]

CommentFileSizeAuthor
#9 3305870-9.patch2.31 KBodai jbr
#7 3305870-7.patch3.06 KBqusai taha
#3 3305870-3.patch2.94 KBrahaf albawab

Issue fork easy_breadcrumb-3305870

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aprice42 created an issue. See original summary.

aprice42 opened merge request !57

rahaf albawab’s picture

rahaf albawab commented
StatusFileSize
new 3305870-3.patch2.94 KB

It working now on multi lengual sites

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Can you update the merge request? It does not appear to be mergable:

https://git.drupalcode.org/project/easy_breadcrumb/-/merge_requests/57

renatog’s picture

renatog commented
Issue tags: +Needs merge request, +Novice
aprice42’s picture

aprice42 commented
Status: Active » Needs review

I rebased the merge request. Looks like it can merge now.

qusai taha’s picture

qusai taha commented
StatusFileSize
new 3305870-7.patch3.06 KB

Re-roll the patch to latest version

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Needs work

patch needs to be committed to the merge request and tested.

odai jbr’s picture

odai jbr commented
Issue tags: -
StatusFileSize
new 3305870-9.patch2.31 KB

Re-roll to work with version 2.0.6

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Awesome. Thanks @odai Jbr. Can you update the merge request so I can get this into the release?

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212

I will work on this issue, and provide the MR.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review

updated the PR kindly review it.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs review » Needs work

It looks like it needs a rebase against the latest 2.0 code so that it's mergeable. The dev release has a buuunch of coding standards fixes that have probably impacted this merge.

spuky made their first commit to this issue’s fork.

spuky’s picture

spuky commented

brought the MR up to dev things to do
- convert \Drupal::routeMatch()->getParameters(); to DI
- fix Unittests

spuky’s picture

spuky commented

Remaining TODOs:
- fix Unittests

spuky’s picture

spuky commented
Status: Needs work » Needs review

fixed the Tests did not try that out yet...

spuky’s picture

spuky commented
Issue tags: -Novice

ericgsmith made their first commit to this issue’s fork.

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Needs work

I've added test coverage.

https://git.drupalcode.org/issue/easy_breadcrumb-3305870/-/jobs/5365762#... shows the error I mentioned in the MR:

There was 1 error:
1) Drupal\Tests\easy_breadcrumb\Functional\EasyBreadcrumbLayoutBuilderTest::testLayoutBuilderSupport
Exception: Warning: Undefined array key "entity_type_id"

After reverting fdf560dd the test now passes : https://git.drupalcode.org/issue/easy_breadcrumb-3305870/-/jobs/5365770

However this reintroduces the phpstan issue.

Have not done a proper review of the code / changes - likely the intent of fdf560dd should still be progress to resolve the issue although now there is test coverage to ensure it works.

Setting to needs work as it either needs the baseline updated / accepted or improvements to not introduce new phpstan issues.