Problem/Motivation

Latest suggested version (3) breaks when installed alongside redirect_404 module (part of redirect).

Steps to reproduce

Install module, try to login with twitter:

TypeError: Argument 7 passed to Drupal\social_auth_twitter\Controller\TwitterAuthController::__construct() must be an instance of Drupal\Core\Logger\LoggerChannelFactory, instance of Drupal\redirect_404\Render\Redirect404LogSuppressor given, called in /var/www/html/web/modules/contrib/social_auth_twitter/src/Controller/TwitterAuthController.php on line 134 in Drupal\social_auth_twitter\Controller\TwitterAuthController->__construct() (line 93 of /var/www/html/web/modules/contrib/social_auth_twitter/src/Controller/TwitterAuthController.php)

Meanwhile, social_auth_google and social_auth_facebook do not have such issues (I don't know if this information helps somehow).

Proposed resolution

Fix it so that it does not break.

Issue fork social_auth_twitter-3305720

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bserem created an issue. See original summary.

bserem’s picture

bserem commented

bserem opened merge request !2

bserem’s picture

bserem commented
Status: Active » Needs review

  • wells committed 81dfd43 on 3.0.x authored by bserem 
    Issue #3305720: Incompatible with redirect_404 module
wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
commented
Status: Needs review » Fixed

Thanks for catching. SA Google and SA Facebook don't inject the logger factory so that's why they don't have this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.