Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#2 cookies.1.1.x-dev.rector.patch787 bytesproject update bot

Issue fork cookies-3305264

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new787 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
anybody’s picture

Priority: Normal » Major
Issue summary: View changes

Drupal 10 is close - the community should ensure 1.1.x works with Drupal 10.
With 2.x we'll drop old dependencies and propably use vue, but 1.1.x should be compatible.

anybody’s picture

Assigned: Unassigned » grevil

@Grevil could you please check 1.1.x for Drupal 10 compatibility, creating a MR from the given patch and implement other required changes please?

Grevil made their first commit to this issue’s fork.

grevil’s picture

Done! I also fixed the php coding standard issues while I was at it :)

anybody’s picture

Status: Needs review » Needs work

Great work! I left some comments to resolve. The hardest part will be the conflicts, I guess due to the changed descriptions.
Please ensure nothing gets lost.

Afterwards this can be merged!

anybody’s picture

PS: Nice, tests are also passing! :party:

grevil’s picture

Status: Needs work » Needs review

OK, all cleaned up now! Let's wait for the tests to pass.

grevil’s picture

Status: Needs review » Reviewed & tested by the community

All green! We can safely commit this! :)

  • Grevil committed eea943b on 1.1.x
    Issue #3305264: Automated Drupal 10 compatibility fixes
    
grevil’s picture

Status: Reviewed & tested by the community » Fixed

Since I don't think any more compability issues will arise, as the D10 release is pretty soon, I am going to close this issue.

grevil’s picture

Status: Fixed » Active

For some reason, I forgot to change the core_version_requirements for the submodules...

  • Grevil committed 3a9d319 on 1.1.x
    Fixed core_version_requirement related to Issue #3305264
    
grevil’s picture

Status: Active » Fixed

Fixed again.

anybody’s picture

@Grevil please set ^8 to ^8.9 to make this safer. So we still support the latest Drupal 8 version (which EOL since long time), but no more older versions.

  • Grevil committed f10233a on 1.1.x
    Fixed core_version_requirement again, related to Issue #3305264
    
grevil’s picture

sry, also added ^8.9

  • Grevil committed 0b8943a on 1.1.x
    Fixed core key, related to Issue #3305264
    
grevil’s picture

Tests should be fixed again, sorry no more direct commits on dev...

Tests failed because of the still existing "core" key in the info ymls.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.