Problem/Motivation

Upgrade Status reported the problem with the following files not having access checks on entity queries:
- web/modules/contrib/facets/tests/src/FunctionalJavascript/JsBase.php line 96
- web/modules/contrib/facets/tests/src/Functional/ExampleContentTrait.php line 31 and 75

There is a related issue where tests are somewhat fixed, but not entirely: Automated Drupal10 compatiblity fixes

Steps to reproduce

Run Upgrade Status checks on the module on D9.5

Proposed resolution

Add accessCheck() to the reported queries.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

Issue fork facets-3305120

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

balintpekker created an issue. See original summary.

balintpekker opened merge request !90

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review

  • balintpekker committed 1497a1d on 2.0.x 
    Issue #3305120: Added accessCheck() to entity queries in tests
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Title: Missing explicit access check on entityQuery » Missing explicit access check on entityQuery in tests
Status: Needs review » Fixed

  • balintpekker committed 1497a1d on 3.0.x 
    Issue #3305120: Added accessCheck() to entity queries in tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.