Problem/Motivation

Since https://www.drupal.org/node/3295096, this happens:

     - Root composer.json requires drupal/core-recommended 9.4.5 -> satisfiable by drupal/core-recommended[9.4.5].
     - drupal/sms[dev-2.x, 2.0.0-alpha1, ..., 2.x-dev] require drupal/telephone * -> satisfiable by drupal/core[8.0.0-beta8, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.4.3, 10.0.0-alpha1, ..., 10.0.0-alpha6].

Steps to reproduce

Install Drupal core 9.4.5 using composer, then try installing smsframework.

Proposed resolution

Update composer.json.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3304584-2.patch382 byteswim leers

Issue fork smsframework-3304584

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3304584-2.patch382 bytes

Just the *.info.yml declarations are sufficient — composer.json dependencies should be for packages, not modules.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Please also credit @effulgentsia, without whom I'd never have found this! 😬

dpi made their first commit to this issue’s fork.

dpi opened merge request !13

dpi credited effulgentsia.

dpi’s picture

dpi
Location Perth, Australia
commented
Title: Update composer.json for Drupal >=9.4.4 compatibility » 3304584-composerjson
dpi’s picture

dpi
Location Perth, Australia
commented
Title: 3304584-composerjson » Update composer.json for Drupal >=9.4.4 compatibility
dpi’s picture

dpi
Location Perth, Australia
commented

Patch URL: https://www.drupal.org/files/issues/2022-08-18/3304584-2.patch
Comment URL: https://www.drupal.org/project/smsframework/issues/3304584#comment-14657312
Issue URL: https://www.drupal.org/project/smsframework/issues/3304584
Patch uploaded by Wim Leers
Commit built with dogit.dev

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Sorry about the trailing comma 😅

And thanks for jumping on this so incredibly quickly! 😮

dpi’s picture

dpi
Location Perth, Australia
commented
Version: 2.2.x-dev » 2.1.x-dev
dpi’s picture

dpi
Location Perth, Australia
commented

@Wim Leers no problem!

  • dpi committed 9641724 on 2.2.x authored by Wim Leers 
    Issue #3304584 by Wim Leers, effulgentsia: Update composer.json for...

  • dpi committed cff89f2 on 2.1.x authored by Wim Leers 
    Issue #3304584 by Wim Leers, effulgentsia: Update composer.json for...

  • dpi committed 43e8c94 on 2.x authored by Wim Leers 
    Issue #3304584 by Wim Leers, effulgentsia: Update composer.json for...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

Changes can be found in 2.0.1 and 2.1.0-beta2

dpi closed merge request !13

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.