Problem/Motivation

As of JavaScript errors thrown in FunctionalJavascript tests are now caught, JS Tests will throw errors if there are js errors present in the console.

As of this, we should move our Tests to Functional JS Tests to also have this covered up

Proposed resolution

Move Tests to Functional JS

Issue fork facebook_pixel-3303137

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Great! :) Thank you!

grevil’s picture

grevil commented

I came to the conclusion, to not move all tests to Functional Javascript, but instead create separate Functional Javascript Tests, since moving the tests would need a lot of refactoring (statusCodeEquals() is not available in JS tests, elements can be invisible, etc.).

Grevil opened merge request !13

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Active » Reviewed & tested by the community

All pass, all good! Great work once again :)

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Perfect! Lets commit this :)

  • Grevil committed 9db2561 on 2.x 
    Issue #3303137: Move Functional Tests to FunctionalJavascript Tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.