commerceguys/addressing 1.4 compatibility

Ran phpstan, these came back as errors.

Something is still broken in the widget. Needs manual review, I just used PHPStan @ level 2 to check.

Raising priority level.

For those landing here after running an update:

Check to see the version of commerceguys/addressing. If it's 1.4.0, try downgrading to 1.3.0.
composer show | grep addressing

composer require "commerceguys/addressing:1.3.0"

Another quick fix:

    "conflict": {
        "drupal/drupal": "*",
        "commerceguys/addressing": ">=1.4.0"
    },

Patch forthcoming.

Patch attached.

Patch #10 works for me, thanks for posting this, I just had this issue when trying to do "drush updatedb" after I did a major update with "composer update"

Patch still has issues:

The test is failing due to:

TypeError: CommerceGuys\Addressing\Validator\Constraints\AddressFormatConstraintValidator::validatePostalCode(): Argument #1 ($postalCode) must be of type string, null given, called in /var/www/html/vendor/commerceguys/addressing/src/Validator/Constraints/AddressFormatConstraintValidator.php on line 82 in CommerceGuys\Addressing\Validator\Constraints\AddressFormatConstraintValidator->validatePostalCode() (line 129 of /var/www/html/vendor/commerceguys/addressing/src/Validator/Constraints/AddressFormatConstraintValidator.php)

The attached patch should fix the tests. Not 100% sure it's the right fix, but it fixes the test at least.

AddressItem fields fetching property values should do ?? '' to handle null values, so that strings are always returned. At least for mandatory items.

Forgot a getter.

Boom.

Committed, thanks everyone!

Hi everyone. Thanks for the work here. Assuming this fix has just been added to the latest dev release? I have one site still on D8 and am seeing this issue also. Any chance someone has patched address 1.9 as yet?

Thanks

Anyone who did #7 - make sure you

composer remove commerceguys/addressing

...to allow the dependency to work. It'll probably throw an error:
"Removal failed, commerceguys/addressing is still present, it may be required by another package. See `composer why commerceguys/addressing`." but in my case, at least, the "remove" command updated it to 1.4.1.

YMMV.

Same here as in #23

For D8, as noted in #3302485: Fatal Error: commerceguys\addressing, it seems the best thing to do is roll back to 1.3.0.

For people who are still in D8 and use the 8.x-1.9 module version, here is a patch to apply, based on commit #20 which only fix types.

Goz, I used with success your patch in Drupal 8.9 thanks !

Thank you Goz !

i don't solve it by Downgrading commerceguys/addressing.

however i face similar error, but with small differences

Fatal error: Declaration of Drupal\address\Repository\CountryRepository::loadDefinitions($locale) must be compatible with CommerceGuys\Addressing\Country\CountryRepository::loadDefinitions(string $locale): array in /home/***/public/modules/contrib/address/src/Repository/CountryRepository.php on line 43

instead on line 38.
my issue are here

And also, Goz Patch doesn't work.

I agree with dratta that the 3302484-28-for-8.x-1.9.patch in #28 does not work, at least not with 'drupal/address:1.9' and the resulting "commerceguys/addressing":"v1.4.2" (resulting from the module's composer.json's requirement of "commerceguys/addressing": "^1.0.7".

This patch is for 'drupal/address:1.9' (last D8 module) and the resulting Composer dependency "commerceguys/addressing":"v1.4.x", tested and working.

Thank you Goz, #28 worked for me!