Problem/Motivation

Make the module Drupal 10 compatible. Upgrade status reported that the info.yml files for sendgrid_integration and sendgrid_integration_reports needs to be updated.

Steps to reproduce

Proposed resolution

Remaining tasks

Update sendgrid_integration.info.yml and sendgrid_integration_reports.info.yml file with the proper core version requirement. Check for deprecations with drupal-check.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork sendgrid_integration-3299971

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

balintpekker created an issue. See original summary.

sharayurajput’s picture

sharayurajput commented

@balintpekker Can i work on this issue ?

balintpekker opened merge request !17

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented

@sharayurajput I pushed up the changes I already had after opening the issue, feel free to review it and add if you see something I missed. I also opened a new issue to remove sendgrid_integration.admin.inc file (https://www.drupal.org/project/sendgrid_integration/issues/3300244) as it is not used anymore and there are a bunch of false positive phpstan issues reported on it.

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: balintpekker » Unassigned
Status: Active » Needs review
sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

okay @balintpekker I will review this issue

sharayurajput’s picture

sharayurajput commented
Status: Needs review » Reviewed & tested by the community

Its looking good and compatible with drupal 10 now so moving to RTBC

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Reviewed & tested by the community » Needs work

Still some small comments from @mglaman, setting as needs work.

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented

Reverted changes to configuration related problems in Api.php, opened follow-up issue: https://www.drupal.org/project/sendgrid_integration/issues/3306626

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Needs review
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, all previous issues were resolved, setting as RTBC.

Perignon made their first commit to this issue’s fork.

perignon’s picture

perignon commented
Status: Reviewed & tested by the community » Fixed

Merged! Thanks for the help and working through the reviews in the PR!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.