Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
It happens so that my entire lading is waiting on this script for seconds...
And it is certainly a GDPR issue.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3299717-external-js-library-fix.patch | 2.12 KB | emptyvoid |
| #2 | 2022-07-25_11h26_12.png | 20.92 KB | maxilein |
Comments
Comment #2
maxilein commentedComment #3
darvanenCan you expand on why you think this is a GDPR issue?
Comment #4
emptyvoid commentedExternal resource throwing a 503 error and blocking all requests.
This causes over 20 second hang to render every single screen on all drupal sites using this module.
https://unpkg.com/slide-element@2/dist/index.umd.js
Comment #5
emptyvoid commentedpatch against 4.x dev branch including external js to remove 20-30 error timeout and page draw holds.
Comment #7
darvanenI'm not comfortable with including the package directly in the module. I've taken a lead from the Webform module and kept the CDN as a fallback while allowing people to install the library in their project in an appropriate location. Thanks for your nudges to get this done.
Comment #8
chandu7929 commentedDue to this changes ExistingSiteJavascript test are failing, its seems that libraries is not available during test.
Note: I have not downloaded the lib locally.
Comment #9
darvanenThanks for calling that out, shouldn't be too difficult to solve, I might have time this weekend but I'm very happy for someone else to take a look at it too. I'm out or I would open a new ticket for this.
Comment #10
chandu7929 commentedCreated child issue for the same.