Problem/Motivation

It happens so that my entire lading is waiting on this script for seconds...
And it is certainly a GDPR issue.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

maxilein created an issue. See original summary.

maxilein’s picture

StatusFileSize
new20.92 KB
darvanen’s picture

Version: 4.0.0-beta1 » 4.x-dev

Can you expand on why you think this is a GDPR issue?

emptyvoid’s picture

External resource throwing a 503 error and blocking all requests.
This causes over 20 second hang to render every single screen on all drupal sites using this module.

https://unpkg.com/slide-element@2/dist/index.umd.js

emptyvoid’s picture

StatusFileSize
new2.12 KB

patch against 4.x dev branch including external js to remove 20-30 error timeout and page draw holds.

  • darvanen authored 9da8291a on 4.x
    Issue #3299717 by emptyvoid, maxilein, darvanen: Collapsiblock Make...
darvanen’s picture

Status: Active » Fixed

I'm not comfortable with including the package directly in the module. I've taken a lead from the Webform module and kept the CDN as a fallback while allowing people to install the library in their project in an appropriate location. Thanks for your nudges to get this done.

chandu7929’s picture

Due to this changes ExistingSiteJavascript test are failing, its seems that libraries is not available during test.
Note: I have not downloaded the lib locally.

darvanen’s picture

Thanks for calling that out, shouldn't be too difficult to solve, I might have time this weekend but I'm very happy for someone else to take a look at it too. I'm out or I would open a new ticket for this.

chandu7929’s picture

Created child issue for the same.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.