Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#4 After patch VU.png51.87 KBAamir M
#4 Before patch VU.png59.22 KBAamir M
#4 Patch VU.png118.6 KBAamir M
#2 views_combine.1.0.x-dev.rector.patch396 bytesproject update bot

Issue fork views_combine-3299440

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new views_combine.1.0.x-dev.rector.patch396 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Aamir M’s picture

Aamir M commented
Assigned: Unassigned » Aamir M
Issue summary: View changes
Aamir M’s picture

Aamir M commented
Assigned: Aamir M » Unassigned
StatusFileSize
new Patch VU.png118.6 KB
new Before patch VU.png59.22 KB
new After patch VU.png51.87 KB

Verified patch #2 on Drupal 10.0.x and 10.1.x. Patch applied successfully and looks good to me.

Testing Steps:

1. Install drupal 10.0.x and 10.1.x version
2. Install Views Union module (1.0.x) version
3. Open drupal 10 or 10.1 and click on Extend
4. Check the Views Union module which unable to install
5. Now apply the patch
6. Reload the page and again check the Views Union module (Note: Clear all caches if required)
7. Now this module is enabled and also install successfully

The module can be installed after applying the patch.
Can be moved to RTBC
RTBC+1

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier opened merge request !14

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

Manoj Raj.R’s picture

Manoj Raj.R commented
Issue summary: View changes

#2 patch looks good to me.
The module can be installed after applying the patch.
Can be moved to RTBC
RTBC+1

mmjvb’s picture

mmjvb commented
Status: Needs review » Reviewed & tested by the community 
docker@d946:/var/www$ composer require drupal/views_combine 1.0.x-dev@dev
./composer.json has been updated
Running composer update drupal/views_combine
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking drupal/views_combine (dev-1.0.x 8db0cc4)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Syncing drupal/views_combine (dev-1.0.x 8db0cc4) into cache
  - Installing drupal/views_combine (dev-1.0.x 8db0cc4): Cloning 8db0cc45f4 from cache
Package doctrine/reflection is abandoned, you should avoid using it. Use roave/better-reflection instead.
Package symfony/debug is abandoned, you should avoid using it. Use symfony/error-handler instead.
Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
Generating autoload files
98 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
docker@d946:/var/www$ drush en views_combine
>  [warning] No configuration objects have been updated.
>  [notice] Message: No configuration objects have been updated.
>
 [success] Successfully enabled: views_combine
docker@d946:/var/www$ drush us-a views_combine
 [notice] Processing /var/www/web/modules/contrib/views_combine.

================================================================================
Views Union, --
Scanned on Wed, 10/19/2022 - 11:57

FILE: web/modules/contrib/views_combine/views_combine.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8 || ^9 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

docker@d946:/var/www$

With https://www.drupal.org/project/infrastructure/issues/3309815 fixed, setting RTBC is no longer considered sabotaging the bot.

  • b_sharpe committed fb5fafd3 on 1.0.x 
    Issue #3299440 by immaculatexavier, Project Update Bot: Automated Drupal...
b_sharpe’s picture

b_sharpe commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.