Group 2.0 upgrade path?

I found a few minutes today to do some initial testing of the patch in #5 above.

Initially, it didn't work due to (I believe) a missing use statement in the patch:

use Drupal\Core\Entity\EntityInterface;

Once I added that, things progressed a bit farther, but I ended up with the following error when running drush updb:

$ drush updb
 -------- ----------- --------------- ------------------------------------------------------------- 
  Module   Update ID   Type            Description                                                  
 -------- ----------- --------------- ------------------------------------------------------------- 
  group    9201        hook_update_n   9201 - Add plugin_id and group_type fields and update        
                                       indexes for group content.                                   
  group    9202        hook_update_n   9202 - Remove the 'bypass group access' permission from all  
                                       roles.                                                       
  group    9203        hook_update_n   9203 - Convert group roles with the 'administer group'       
                                       permission to admin roles.                                   
  group    9204        hook_update_n   9204 - Convert synchronized group roles to new scope and     
                                       target_role structure.                                       
  group    9205        hook_update_n   9205 - Convert default group roles to new scope and          
                                       target_role structure.                                       
  group    9206        hook_update_n   9206 - Convert user created group roles to new scope and     
                                       target_role structure.                                       
  group    9207        hook_update_n   9207 - Remove label and description from group content       
                                       types.                                                       
 -------- ----------- --------------- ------------------------------------------------------------- 


 Do you wish to run the specified pending updates? (yes/no) [yes]:
 > 

>  [notice] Update started: group_update_9201
>  [error]  Call to undefined method Drupal\group\Entity\GroupContent::getRelationshipType() 
>  [error]  Update failed: group_update_9201 
 [error]  Update aborted by: group_update_9201 
 [error]  Finished performing updates. 

I hope this is helpful.

Thanks, @kristiaanvandeneynde for your diligence on this issue!

-mike

Still no luck, unfortunately. Here's what I did:

1. I updated both Group and Flexible Permissions to their latest dev versions.

2. I tried to rebuild caches, but consistently received the error:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
                                                                                                   
  The service "group_permission.calculator" has a dependency on a non-existent service "flexible_  
  permissions.chain_calculator"

Looking at flexible_permissions.services.yml, the "flexible_permissions.chain_calculator" is indeed listed.

3. I tried to run a database update, but it failed as well:

$ drush updb
 ---------- ---------------------- --------------- ------------------------------------------------ 
  Module     Update ID              Type            Description                                     
 ---------- ---------------------- --------------- ------------------------------------------------ 
  group      9201                   hook_update_n   9201 - Add plugin_id and group_type fields and  
                                                    update indexes for group_content.               
  group      9202                   hook_update_n   9202 - Remove the 'bypass group access'         
                                                    permission from all roles.                      
  group      9203                   hook_update_n   9203 - Convert group roles with the             
                                                    'administer group' permission to admin roles.   
  group      9204                   hook_update_n   9204 - Convert synchronized group roles to new  
                                                    scope and target_role structure.                
  group      9205                   hook_update_n   9205 - Convert default group roles to new       
                                                    scope and target_role structure.                
  group      9206                   hook_update_n   9206 - Convert user created group roles to new  
                                                    scope and target_role structure.                
  group      9207                   hook_update_n   9207 - Remove label and description from        
                                                    relationship types.                             
  group      9208                   hook_update_n   9208 - Introduce the group_config_wrapper       
                                                    entity type.                                                
 ---------- ---------------------- --------------- ------------------------------------------------ 


 Do you wish to run the specified pending updates? (yes/no) [yes]:
 > 

>  [notice] Update started: group_update_9201
>  [error]  The entity schema update for the group_content entity type requires a data migration. 
>  [error]  Update failed: group_update_9201 
 [error]  Update aborted by: group_update_9201 
 [error]  Finished performing updates. 

Thoughts?

-mike

No luck - similar, but not exact issue.

1. drush cr leads to the

The service "group_permission.calculator" has a dependency on a non-existent service "flexible_  
  permissions.chain_calculator"

error.

2. drush updb leads to a new error:

>  [notice] Update started: group_update_9201
>  [error]  It is not possible to change the entity type schema outside of a batch context. Use EntityDefinitionUpdateManagerInterface::updateFieldableEntityType() instead. 
>  [error]  Update failed: group_update_9201 
 [error]  Update aborted by: group_update_9201 
 [error]  Finished performing updates. 

-mike

So far, so good. I was able to upgrade from 1.x to 2.x using the instructions in comment 16.

But, after I did so, I was looking at a list of nodes belonging to one of my groups (via /group/1/nodes) and there is something odd going on.

• This group has two members - user IDs 1 and 3.
• This group has three nodes - node IDs 1, 3, 4.
• When I click to "View relation" for NID=3 (/group/1/content/3), I actually see the relation for UID=3, not NID=3.
• When I click to "View relation" for NID=4 (/group/1/content/2), I actually see the relation for a node I had previously deleted.
• When I click to "View relation" for NID=1 (/group/1/content/1), I actually see the relation for UID=1, not NID=1.
• The "View member" links from /group/1/members appear to be working fine.
• The "All entities" tab (/group/1/content) show 3 entities - UIDs 1 and 3 and NID=4, but not NIDs 1 nor 3.

It seems like something is getting confused with different entity types.

When I click "Add existing content" from /group/1/nodes, I get a blank page (the title and breadcrumbs are there, but no page content). Same for "Add new content".

Is this a bug with the upgrade path or something else?

-mike

After further review, I think my comment #17 above was not correct, and therefore I'm pretty sure all is good.

I believe that originally, my group did not have 3 nodes, but only 1.

I was also confused that when I clicked on a node title on the "All entities" page (/group/1/content) I wasn't seeing the node, but rather the group relationship.

-mike