Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new1.38 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
anybody’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch looks good, but we have to remove the Drupal 8 compatibility and add ^9.4 || ^10 compatibility as that's missing in the patch.

grevil’s picture

Status: Reviewed & tested by the community » Needs work

Yea patch looks almost fine, although we should use dependency injection instead of the direct service call.

grevil’s picture

Status: Needs work » Needs review
StatusFileSize
new3.51 KB

I created a patch with the additional dependency injection and info file change

grevil’s picture

Status: Needs review » Active
StatusFileSize
new4.13 KB

I accidentally staged the changes from "micon.2.x-dev.rector.patch" so my patch, patched on top of the other patch. Although this might be good for later, in case more functions get deprecated in D10.

grevil’s picture

Title: Automated Drupal 10 compatibility fixes » Automated Drupal 10 compatibility fixes (FIXED)
omkar-pd’s picture

Tried to install the module in d10 using patch #6. Getting the following error.

The website encountered an unexpected error. Please try again later.
Error: Class "Twig_Extension" not found in include() (line 11 of modules/contrib/micon/src/TwigExtension/Micon.php).
grevil’s picture

Status: Active » Needs work

Thank you @omkar-pd!
Neither me nor the Drupal Bot picked that up! Nice find!

deprecated since — Twig 2.7, use "Twig\Extension\AbstractExtension" instead

grevil’s picture

Title: Automated Drupal 10 compatibility fixes (FIXED) » Automated Drupal 10 compatibility fixes
omkar-pd’s picture

StatusFileSize
new85.09 KB

One more thing:-
The patch does not make sub-modules compatible with d10.

grevil’s picture

Status: Needs work » Needs review
StatusFileSize
new8.4 KB

Thank again @omkar-pd!

I provided a new patch with the relevant changes. Works fine for Drupal 9. @omkar-pd can you confirm this also applies for Drupal 10?

Note, that as of #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6 micon_linkit will have problems either way with everything above D8!

grevil’s picture

StatusFileSize
new8.4 KB

Sry wrong patch again! Generally using issue forks instead of patches... my bad.

See provided patch.

anybody’s picture

micon_linkit is only Drupal ^8.9 compatible currently due to this issue: #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6

That's a special thing and has to be fixed.
Furthermore I'd suggest one of the following:
a) core_version_requirement: ^8.9 || ^9 || ^10
b) ^9.4 || ^10 for 2.1.x (my favorite).

Otherwise we may have to fight with old dependencies or drawbacks while Drupal 8 is EOL since month ago and Drupal 8 users can still use 2.0.x!

That should be used for the main module and all submodules.

By that micon_linkit is currently unusable until #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6 is fixed, but at least we point that out and don't let people run into the errors. Sooner or later that issue will hopefully be entirely fixed.

grevil’s picture

StatusFileSize
new8.35 KB

Thanks, @Anybody! Created a new patch accordingly.

anybody’s picture

Status: Needs review » Needs work

Looks unfixable to me for the tests?

So I think we have to postpone this on a proper fix for #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6 or commit without green lights... -.-

grevil’s picture

Status: Needs work » Active

Since #3273973: Make Micon Linkit Widget compatible with Linkit:^5 || ^6 is closed now, we can re-roll the patch and apply it to dev.

grevil’s picture

Status: Active » Needs review
StatusFileSize
new7.86 KB

Patch re-rolled and applies just fine!

grevil’s picture

Title: Automated Drupal 10 compatibility fixes » Automated Drupal 10 compatibility fixes (FIXED)
Status: Needs review » Active

OK, I tested the module using Drupal 9 and everything seems to work just fine! Should be the same for a Drupal 10 instance, since all deprecated code (as of this writing) got replaced!

@omkar-pd please let us know if there are any further Drupal 10 issues, I will commit the current changes to dev and keep this issue open, so you or the Drupal Bot can make patch additions.

  • Grevil committed 8201de3 on 2.x
    Issue #3297653 by Grevil, Project Update Bot, omkar-pd: Automated Drupal...
omkar-pd’s picture

Applied the patch and all the modules were installed cleanly except Micon Linkit. Code looks good as well.

grevil’s picture

@omkar-pd, perfect thank you!

omkar-pd’s picture

Happy to contribute :)

project update bot’s picture

anybody’s picture

Issue summary: View changes
Status: Active » Fixed

Time to close this :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

grevil’s picture

Overlooked the child issue! :O

Hence, this module is not truely D10 ready yet!!