Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#7 media_embed_extra.1.0.x-dev.rector-2.patch505 bytesaurora.luzzardi
#2 media_embed_extra.1.0.x-dev.rector.patch427 bytesproject update bot

Issue fork media_embed_extra-3297597

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new media_embed_extra.1.0.x-dev.rector.patch427 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0

Anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes

Created a MR, as the patch is not correct.

Should use core_version_requirement: ^8.8 || ^9 || ^10 as it was introduced in 8.7.7!
If we want to be very sure, we should even use ^8.9 as last Drupal 8 version.

See https://www.drupal.org/node/3070687

Anybody opened merge request !2

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

Merging MR!2 should also fix core updating issues with this module like in https://drupal.stackexchange.com/questions/312436/why-is-composer-refusi... I guess.

For that reason I'm setting this major, while the Drupal 10 compatibility of course isn't major (yet!).
@Maintainer: Please create a beta2 release afterwards!

PS: Also see #3303839: Not compatible with Drupal Core 9.4.5 before and try the fixes, perhaps I'm wrong with my assumption!

aurora.luzzardi’s picture

aurora.luzzardi
she/her/hers
Location Pelotas, RS
commented
StatusFileSize
new media_embed_extra.1.0.x-dev.rector-2.patch505 bytes

That patch and MR is not working, you should remove the 8 versions it already reached the end of live.
Here is a patch to fix

aluzzardi opened merge request !3

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

I disagree, there's no reason why Drupal >= 8.8 should not be supported anymore if there are no changes which require a higher version in the module.

core_version_requirement syntax is available in Drupal since 8.8!

watergate’s picture

watergate commented
Status: Needs review » Reviewed & tested by the community

Changes seem fine, and I agree with @Anybody that this is a significant issue since it is holding back updating Drupal core to the latest version (i.e., 9.4.5).

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

@Watergate Curious if you were working on this as part of the Drupal 10 Global Porting Day?

watergate’s picture

watergate commented

@Kristen Pol, no, I just couldn't update a website to Drupal core 9.4.5 because it uses this module. But I think it's a plus that this patch/merge request makes this module Drupal 10 ready :)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks for the update! Glad you got what you needed for your site :)

hkirsman’s picture

hkirsman commented

Would be nice to get this in and new release!

dydave’s picture

dydave commented

Thank you very much for contributing this issue and provide a patch.

We would like to confirm the patch from #7 fixes the issue we have been having with composer refusing the update project, see related #3305951-3: Can't install for Drupal 9.4.5.

Tested with:

  • Drupal core 9.4.3,
  • composer 2.4.1,
  • PHP: 7.3,
  • media_embed_extra:1.0.0-beta1

 

Since we're using the module as a dependency in a composer.json template, we are unable to use the forked version, since project's root composer.json doesn't load repositories from its dependencies.
Therefore, we've tried contacting module's maintainer through Drupal.org standard contact form, which should perhaps hopefully help getting the patch committed.

Unfortunately, for the time being, our best option for our given project would be to remove the package from the "sub" composer.json to be moved to custom modules, until a dev version can be made available, with the patch.

We would greatly appreciate if a maintainer or someone with write access to project's repository could have a look at the patch and merge requests.
Thanks in advance.

Ericmaster made their first commit to this issue’s fork.

ericmaster’s picture

ericmaster commented
Status: Reviewed & tested by the community » Fixed

Merged the PR, will be doing a new release soon. Thanks for your patience and sorry for the delay!

dydave’s picture

dydave commented

Thanks a lot Eric!

Glad we can move forward on this issue and add the module back to our project's composer file.

Thanks again to everyone for your help with this issue.

mmjvb’s picture

mmjvb commented

Any reason for ignoring the good advice of @Anybody ?

Consider it bad what you are doing for several reasons. But, that is your prerogative as maintainer.

Reasons for being bad:
- You introduce scope creep in the issue. Removing support for D8 has nothing to do with adding support for D10. Definitely not with automated fixes.
- Removing support requires at least a minor release when following Semantic Versioning. It is definitely not a bug fix.
- Would expect a separate branche for the next minor due to name of current branch where you would apply this commit.

ericmaster’s picture

ericmaster commented

I meant to merge Anybody's MR, sorry about that, just too many things on my head lately. It should have D8 support back.

ericmaster’s picture

ericmaster commented
Status: Fixed » Closed (fixed)
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips