Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#10 3296930-8.patch9.97 KBekes
#6 Drupal-10-upgrade-status-95 (11).png32.84 KByashingole
#6 Module-Permissions-10 (3).png66.08 KByashingole
#6 Add-field-10 (1).png51.91 KByashingole
#6 rdf1-10.png85.98 KByashingole
#5 3296930-5.patch7.71 KBheddn
#5 interdiff_2-5.txt3.6 KBheddn
#2 date_recur_modular.3.x-dev.rector.patch4.11 KBproject update bot

Issue fork date_recur_modular-3296930

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new date_recur_modular.3.x-dev.rector.patch4.11 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
dpi’s picture

dpi
Location Perth, Australia
commented
Issue summary: View changes

Drupal 10 support will be addressed in the near future. It is not currently a priority.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work

In addition to what the bot was able to fix, there's also:

  1. web/modules/contrib/date_recur_modular/templates/date-recur-modular-sierra-widget.html.twig 0 The spaceless tag in "modules/contrib/date_recur_modular/templates/date-recur-modular-sierra-widget.html.twig" at line 3 is deprecated since Twig 2.7, use the "spaceless" filter with the "apply" tag instead. See https://drupal.org/node/3071078..
  2. web/modules/contrib/date_recur_modular/date_recur_modular.libraries.yml 0 The 'date_recur_modular_sierra_widget' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256

Since drupal 10 is now released, this seems a bit more important now.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_2-5.txt3.6 KB
new 3296930-5.patch7.71 KB

This should do the trick. I bumped the minimum version of drupal core to 9.2 given we have to support the new once js library. Which was only made available in that version.

yashingole’s picture

yashingole commented
StatusFileSize
new rdf1-10.png85.98 KB
new Add-field-10 (1).png51.91 KB
new Module-Permissions-10 (3).png66.08 KB
new Drupal-10-upgrade-status-95 (11).png32.84 KB

I have reviewed and checked Patch #5 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 and the Permission page along with the Field added page on 10 have been attached for reference:

stephen-cox made their first commit to this issue’s fork.

ekes made their first commit to this issue’s fork.

ekes opened merge request !4

ekes’s picture

ekes commented
StatusFileSize
new 3296930-8.patch9.97 KB

Issue fork date_recur_modular-3296930 3.x branch contains:-

  1. Applied patch by @heddn for Drupal 10 support #3296930 Stephen Cox Which has the automated updates, plus work that was required to fix the javascript in the sierra widget;
  2. Issue #3296930: Fix tests for 10.x ekes Updates the tests to use 10.x compatible stark in place of classy, requiring one selector change;
  3. Issue #3301519: The specified #ajax callback is empty or not callable Alex Sharkov Required to make Sierra work with PHP 8+, a Drupal 10 requirement.

Also attaching patch version of the branch to this.

ifrik’s picture

ifrik
she/her
commented
Status: Needs review » Reviewed & tested by the community

I've tested this for the form widgets "Modular: Sierra" (with "Default interpreter"), "Modular: Oscar" and "Modular: Alpha" with the different options in each widget enabled and disabled.

They all work as expected. Dates and their recurrence can be changed and changing the widget also works fine.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Confirming #10 is RTBC, nice work here everyone!

  • dpi committed 93b02a44 on 3.x 
    Issue #3296930 by heddn: Drupal 10 compatibility

  • dpi committed a66f96f1 on 3.x authored by ekes 
    Issue #3296930 by ekes: Fix tests

  • dpi committed 94139178 on 3.x 
    Issue #3296930: Automated Drupal 10 compatibility fixes
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Reviewed & tested by the community » Fixed

A handful of commits can be found in 3.1.0-rc1.

Note minor changes for PHP + core + dependent constraints: PHP 8.0, Core >=9.5, Recurring Date Field 3.2.

Thanks everyone

dpi’s picture

dpi
Location Perth, Australia
commented
Title: Automated Drupal 10 compatibility fixes » Drupal 10 compatibility

dpi closed merge request !4

dpi’s picture

dpi
Location Perth, Australia
commented
Version: 3.x-dev » 3.1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.