Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the patch in the comment by Project Update Bot.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
| Comment | File | Size | Author |
|---|
Issue fork contact_permissions-3296873
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
j-leePatches from bot looks good.
The changes to the info files could be done on commit:
contact_permissions.info.yml
tests/modules/contact_permissions_test/contact_permissions_test.info.yml
Comment #5
plopescPatch updated to inclde .info.yml files changes
Comment #6
j-leeLooks good to me.
Comment #8
piridium commentedPatch #5 did not apply to the composer installed version 2.0.0. There seems to be an issue with the .info.yml files.
I guess this is caused by the information added by Drupal.org packaging script. Can someone with more knowledge about patching tell if that's what's going on?
This new patch should work for the version 2.0.0 installed with composer.
Comment #9
j-lee@piridium can you please add your changes to the merge request?
Comment #10
astonvictor commentedIt still needs some work.
e.g. we need to remove
core: 8.xfrom the info file.Also, we need to add default files such as composer.json, Readme.md and implement
hook_help()Comment #11
piridium commented@j-lee There are absolutely no difference in the changes between my patch and your merge request. The only difference is some patch metadata which, I guess, relates to the information added to info.yml files by the packaging script.
Your merge request is still totally valid and up to date.
Comment #12
astonvictor commentedUpdated the MR.
Added readme.md file, composer.json file, implemented
hook_help()and refactored the code. Please, review it.Comment #13
astonvictor commentedComment #14
manuel garcia commentedComment #15
astonvictor commentedHi @Manuel,
I applied your suggestions.
thanks
Comment #16
manuel garcia commentedComment #18
manuel garcia commentedThank you everyone who helped with this, I've now comitted the changes and cut a new 3.0.0 release: https://www.drupal.org/project/contact_permissions/releases/3.0.0