Problem/Motivation

Make the module Drupal 10 compatible on 6.0.x.

Upgrade Status shows the following issue:
Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: in /tests/src/Unit/DataParserPluginBaseTest.php

Also, there are some other issues reported by drupal-check needed to be fixed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3294980-8.patch583 bytesmglaman

Issue fork migrate_plus-3294980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

balintpekker created an issue. See original summary.

balintpekker opened merge request !68

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
CreditAttribution: balintpekker commented

Drupal 10 will need Guzzle 7, and until https://github.com/Sainsburys/guzzle-oauth2-plugin/pull/21 is merged the suggested sainsburys/guzzle-oauth2-plugin package will have conflicts. Also, it is not a required package currently, however for the Oauth2 authentication plugin to work, you need it, so it's a soft dependency. I'd suggest moving the package to the require-dev section of the composer.json file.

balintpekker’s picture

balintpekker
he/him
Primary language Hungarian
Location Budapest, Hungary
CreditAttribution: balintpekker commented
Status: Active » Needs review
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Assigned: balintpekker » Unassigned
Status: Needs review » Postponed (maintainer needs more info)

This is already a Drupal 10 compatible release:

https://www.drupal.org/project/migrate_plus/releases/6.0.0

so I assume should be closed.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Status: Postponed (maintainer needs more info) » Needs review

Oh, this looks like an additional issue that was missed by the original patch?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Acquia commented
Status: Needs review » Needs work

@balintpekker the MR makes too many changes. Rebase is on 6.x to fix 

   return $this->getMockBuilder(DataParserPluginBaseMock::class)
      ->setConstructorArgs([$configuration, $plugin_id, $plugin_definition])
      ->setMethods(['openSourceUrl'])
      ->getMockForAbstractClass();

setMethods is deprecated. Let's get in the surgical fix for just that.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Acquia commented
Title: Drupal 10 compatibility fixes » Call to deprecated method setMethods()
Status: Needs work » Needs review
FileSize
3294980-8.patch583 bytes

Here's the fix for the deprecated PHPUnit method. Retitling so it's more specific to the fix.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, since its a minor thing and tests are passing, I'm setting this as RTBC.

  • heddn committed cbf70e8 on 6.0.x 
    Issue #3294980 by mglaman, heddn: Call to deprecated method setMethods()
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.