Problem/Motivation
The string for the separator between start and end date in the inline widget (smartdate_inline) is currently set to "$this->t('to');". "to" is a somewhat general word and in some languages (i.e. german) might have different meaning depending on the context it is used in. So I am somewhat afraid of changing this translation generally to make it fit the smart date context.
Maybe one could add a translation context to this. But I am proposing to have a widget setting that enables to set an arbitrary string for the separator (and in case it is not set, the default "$this->t('to')" will be used. I suppose that arbitrary string could be translated through config translation if necessary.
Steps to reproduce
Use the inline widget (smartdata_inline) and see the separator string ("to" in englisch, "zu" in german by default, which should better be "bis" in german).
Proposed resolution
add a setting to the widget to let us have a custom separator string
Remaining tasks
na
User interface changes
a custom separator string can be used.
API changes
na
Data model changes
na
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | inline_widget_separator-3294159-002.patch | 2.98 KB | stefan.korn |
Comments
Comment #2
stefan.kornComment #4
mandclu commentedThanks for suggesting this, and for providing code to implement it. I made one small change so it would default to the current separator, and merged this into a new 3.7.x branch. Will roll a new release shortly.
Comment #6
stefan.korn@Martin: I opened an issue with Gin #3378990: bottom margin in multi value field table display that relates to the separator string in smart date, but is a more general gin issue imho. Just wanted lo let you know, so you maybe can have a say in the Gin issue as well or just for your information.
Nothing new to this issue though.