Problem/Motivation

When external storage like Azure Blob Storage File System is configured and a .gif without animation is uploaded, the isAnAnimatedGif() check never stops.
The reason is that the file end is not properly detected.

Steps to reproduce

Issue fork animated_gif-3293096

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

frouco created an issue. See original summary.

frouco opened merge request !5

frouco’s picture

frouco commented
Assigned: frouco » Unassigned
Status: Active » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Needs work

Hi,

Thanks for the issue and MR.

See my review comment and tests should pass.

frouco’s picture

frouco commented
Status: Needs work » Needs review

Hi,
corrections done and tests in green

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

Deprecation had not been catched by PHPStan or Rector.

For the record this is this Change record: https://www.drupal.org/node/3180429

I am going to merge and make a new release.

  • Grimreaper committed ba35a7c on 2.0.x authored by frouco 
    Issue #3293096 by frouco, Grimreaper: The end of the file is not...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 2.0.0 » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.