Adding patches to the main composer.json file just clutters things, they should be moved to a separate composer.patches.json file.

CommentFileSizeAuthor
#4 interdiff_2-3.txt1.49 KBimmaculatexavier
#4 3292009-3.patch3.44 KBimmaculatexavier
#3 3292009-2.patch1.88 KBimmaculatexavier

Issue fork dropsolid_rocketship-3292009

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Matthijs created an issue. See original summary.

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier’s picture

immaculatexavier commented
Status: Active » Needs review
StatusFileSize
new 3292009-2.patch1.88 KB

Moved patches to composer.patches.json file.
Kindly review

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 3292009-3.patch3.44 KB
new interdiff_2-3.txt1.49 KB

In #2 missed to add one file. So attaching updated patch with interdiff

mallezie made their first commit to this issue’s fork.

mallezie opened merge request !8

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Title: Move patches to composer.patches.json file » Cleanup composer.json file

Hijacking the issue to also include some cleanup for the composer.json file.

Internal issues: https://redmine.dropsolid.com/issues/121449 and https://redmine.dropsolid.com/issues/121237

sdstyles’s picture

sdstyles commented
Status: Needs review » Reviewed & tested by the community

Looks good, no composer errors during installation.

nginex’s picture

nginex commented
Assigned: Unassigned » nginex
Status: Reviewed & tested by the community » Needs work

going to reroll

nginex’s picture

nginex commented
Version: 10.0.x-dev » 10.1.x-dev
Assigned: nginex » Unassigned
Status: Needs work » Needs review

  • nginex committed 957fe368 on 10.1.x 
    [#3292009] Create composer.patches file. Cleanup composer.json....
nginex’s picture

nginex commented
Status: Needs review » Fixed

  • nginex committed dd503f5f on 10.1.x 
    Issue #3292009: Revert some properties to support custom package.
nginex’s picture

nginex commented

I kept name, description, license, and authors. The reason is that we use this repo for a package https://packagist.org/packages/dropsolid/rocketship#10.1.1 so it's possible to create with composer create-project.

Without these properties it will not work, so I suggest to manually cleam up them after you started a new project.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.