Problem/Motivation
The stub release of 10.1.x without any real code in it breaks several/most/all installer tests in 10.0.x
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3291893
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3291893-stub-release-for
changes, plain diff MR !2424
Comments
Comment #3
spokjeAh, only after creating this issue I've noticed #3291877: Fix \Drupal\FunctionalTests\Installer\InstallerTestBase tests to not test drupal.org where @alexpott found the same problem and tries to resolve it in a much more elaborate way. :/
Happy for Bigger Brains to decide what approach to take.
Comment #4
alexpottI think we do both approaches. This will fix the problem everywhere but #3291877: Fix \Drupal\FunctionalTests\Installer\InstallerTestBase tests to not test drupal.org will result in less unexpected update module installs.
Comment #5
spokjeComment #6
alexpottI think the change here should be a little more conservative. I think we should do something like
We currently failing here:
As this only concerns dev snapshots I think only ignoring dev releases is way safer.
Comment #7
spokjeMade changes.
Comment #8
spokjeFollow-up created to create a test case for this fix: #3291904: Create a test for a dev release without a date
Comment #9
spokjeComment #10
alexpottThanks @Spokje - as we can see from #2 this fixes the broken tests on 10.0.x which is great. It also stops the update module from recommend 10.1.x to anyone which feels good too. And I think the latest changes in #7 make this as safe a change as we can make.
This issue addresses the broken tests, improves the UI, and does so in as limited a way possible => RTBC.
An alternative fix would be to update the 10.1.x branch to 6d457761e2 - i.e the first commit for Drupal 10... that would allow packaging to create a release. That's something for the release managers to decide.
Comment #12
catchCommitted/pushed to 10.0.x, thanks!