Problem/Motivation

Discovered whilst working on #3227033: Remove Quick Edit from core.

The CKEditor 4 & 5 modules in Drupal core contain CSS to ensure they look good while used by Quick Edit:

  1. core/modules/ckeditor/css/ckeditor.css
  2. core/modules/ckeditor5/css/quickedit.css

Since Quick Edit is on it's way out of core (and live long and prosper in Contrib) we need to move this file and namespace to the land of quickedit.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3291047-5.patch8.15 KBwim leers
#5 interdiff.txt4.94 KBwim leers
#3 3291047-2-proper.patch3.24 KBwim leers
#2 3291047-2.patch3.32 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3291047-2.patch3.32 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 3291047-2-proper.patch3.24 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3291047-2-proper.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt4.94 KB
new 3291047-5.patch8.15 KB

This means we now need stable and stable9 overrides 😬

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

- Green Testbot
- Patch created by "Mr. CKEditor(5)'
- Blocker for deprecating/removing Quick Edit

More than enough reasons for RTBC.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

hehe :P

One remark:

+++ b/core/themes/stable/stable.info.yml
@@ -188,6 +188,11 @@ libraries-override:
+  quickedit/quickedit.inPlaceEditor.formattedText:
+    css:
+      component:
+        css/editors/formattedText.ckeditor.css: css/quickedit/editors/formattedText.ckeditor.css
+        css/editors/formattedText.ckeditor5.css: css/quickedit/editors/formattedText.ckeditor5.css

+++ b/core/themes/stable9/stable9.info.yml
@@ -208,6 +208,11 @@ libraries-override:
+  quickedit/quickedit.inPlaceEditor.formattedText:
+    css:
+      component:
+        css/editors/formattedText.ckeditor.css: css/quickedit/editors/formattedText.ckeditor.css
+        css/editors/formattedText.ckeditor5.css: css/quickedit/editors/formattedText.ckeditor5.css

I'm not certain that these are necessary in this particular case. We're adding these CSS files to stable and stable9 even though Quick Edit is about to be removed.

The better approach might be to add this library to \Drupal\KernelTests\Core\Theme\StableLibraryOverrideTestBase::$librariesToSkip instead.

I'm not familiar enough with the policies around this to know — so leaving that up to the core committers/front end framework managers to decide 😊

If that approach is deemed better: start from #3, ignore #5, and just add quickedit/quickedit.inPlaceEditor.formattedText to \Drupal\KernelTests\Core\Theme\StableLibraryOverrideTestBase::$librariesToSkip.

  • catch committed e47f94c on 10.0.x 
    Issue #3291047 by Wim Leers, Spokje: Move Quick Edit-specific styling of...

  • catch committed 18693c0 on 9.5.x 
    Issue #3291047 by Wim Leers, Spokje: Move Quick Edit-specific styling of...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks good. Only hesitation about committing it is every time we do, we find another blocker...

Committed/pushed to 10.0.x and cherry-picked to 9.5.x, thanks!

I think it's OK if we remove the stable CSS at the same time as removing quickedit in 10.0.x.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I think it's OK if we remove the stable CSS at the same time as removing quickedit in 10.0.x.

WFM!

spokje’s picture

spokje
Primary language Dutch
commented
Version: 9.5.x-dev » 9.4.x-dev
Assigned: Unassigned » spokje
Status: Fixed » Patch (to be ported)
spokje’s picture

spokje
Primary language Dutch
commented

Patch 3291047-5.patch will apply cleanly on 9.4.x after #3267258: Remove Quick Edit support from editor.module has been committed.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module » [PP-1] Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module
Status: Patch (to be ported) » Postponed

No deprecation errors to be changed in this one, there aren't any.

We should however update the CR when this gets committed.

Postponing on the commit of #3267258: Remove Quick Edit support from editor.module

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module » Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module
Version: 9.4.x-dev » 9.5.x-dev
Status: Postponed » Fixed

Not backporting this any more.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.