Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3289899_11.patch | 7.63 KB | mark_fullmer |
| #11 | 3289899_9-11.interdiff.txt | 7.03 KB | mark_fullmer |
| #6 | Before-resolving-error.png.png | 105.07 KB | dharti patel |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
jurgenhaasMerged #2
Comment #5
dharti patel commentedComment #6
dharti patel commentedHello,
Resloved all the issues and create a patch for the same.
Kindly pelase review it.
Thanks
Comment #7
himanshu_jhaloya commentedHi @Dharti Patel I am reviewing the patch #6
Comment #8
himanshu_jhaloya commentedHi @Dharti Patel Please attach the patch
Comment #9
dharti patel commentedComment #10
dharti patel commentedHello,
Resloved the issues and create a patch for the same.
Thanks!
Comment #11
mark_fullmer1. The patch in #9 moves the $file object syntax so that it is no longer triggering a drupal-check error (see screenshot of #6), but the use statement for the File class (i.e.,
use Drupal\file\Entity\File) should be removed and the inline @var comment syntax needs to be adjusted.2. The SimpleXMLElement is a native PHP class so should not be referenced in a use statement (
use SimpleXMLElement).3. A number of class elements do not have Drupal-standard doc blocks.
The attached patch resolves these items (interdiff attached, as well).
Comment #12
kristen polFixing tag.
Comment #14
jurgenhaasThanks @mark_fullmer I've just committed your patch and added a couple of minor additional fixes too. Setting this issue back to active, so that the bot can submit further suggestions if needed.
Comment #15
kristen polThanks, all, for helping during the porting event!
@jurgenhaas Thanks for committing and for explaining why the issue is moving back to Active so people do not test it anymore :)
Comment #16
jurgenhaas@Kristen Pol thanks for moderating this enormous effort!
Comment #17
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #19
jurgenhaas