Automated Drupal 10 compatibility fixes [#3289146]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#12	private_content.d10.3289146-interdiff-10-12.txt	347 bytes	adamps
#12	private_content.d10.3289146-12.patch	825 bytes	adamps
#10	private_content.d10.3289146-interdiff-9-10.txt	322 bytes	adamps
#10	private_content.d10.3289146-10.patch	814 bytes	adamps
#9	private_content.d10.3289146-9.patch	400 bytes	adamps
#2	private_content.2.x-dev.rector.patch	406 bytes	project update bot

Comments

Comment #1

16 June 2022 at 04:44

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 16 June 2022 at 04:44

Status:

Active

» Needs review

Status	File	Size
new	private_content.2.x-dev.rector.patch	406 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.9
palantirnet/drupal-rector: 0.12.0

Comment #3

project update bot commented 17 October 2022 at 17:53

Issue summary:

View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

Comment #4

joseph.olstad

French

commented 29 July 2023 at 19:29

It's time ! Let's get this in. Due to this not being in, I have to perform a composer circus to get my composer build working with D10.

Comment #5

joseph.olstad

French

commented 29 July 2023 at 20:05

Issue summary:

View changes

Here's the composer circus I'm using to get around the lack of a tagged release with D10 compatibility included. It's not that hard to do but it takes a bit of effort that would normally be simple.

Add this to your repo section in your composer.json file if you have a repo section you can add it in, if you don't have one, add a repo section, check with composer documentation online on how to do this if you've never done it.

{
      "type": "package",
      "package": {
        "name": "drupaloverride/private_content",
        "version": "dev-53138c26",
        "type": "drupal-module",
        "dist": {
          "type": "zip",
          "url": "https://git.drupalcode.org/api/v4/projects/project%2Fprivate_content/repository/archive.zip?sha=53138c26"
        }
      }
    }

Patch the workaround project invented in your composer.json (add this to your patches section):

    "drupaloverride/private_content": {
      "3289146 - D10 compatibility": "https://www.drupal.org/files/issues/2022-06-16/private_content.2.x-dev.rector.patch"
    },

composer require drupaloverride/private_content:'dev-53138c26'

If you are a composer guru this should be fairly quick to figure out. Otherwise, good luck, I recommend someone commit the above patch and tag/publish a release asap.

Comment #6

joseph.olstad

French

commented 29 July 2023 at 20:09

Status:

Needs review

» Reviewed & tested by the community

Comment #7

adamps commented 31 July 2023 at 10:54

Thanks for the comment. So the module works on D10 for you with this patch?

Comment #8

joseph.olstad

French

commented 31 July 2023 at 12:21

Yes it does work.

Comment #9

adamps commented 1 August 2023 at 10:17

Status	File	Size
new	private_content.d10.3289146-9.patch	400 bytes

Comment #10

adamps commented 1 August 2023 at 10:37

Status:

Reviewed & tested by the community

» Needs review

Status	File	Size
new	private_content.d10.3289146-10.patch	814 bytes
new	private_content.d10.3289146-interdiff-9-10.txt	322 bytes

Comment #11

adamps commented 1 August 2023 at 10:38

2 files were hidden/shown/deleted

Status	File	Size
hidden	private_content.2.x-dev.rector.patch	406 bytes
hidden	private_content.d10.3289146-9.patch	400 bytes

Comment #12

adamps commented 1 August 2023 at 10:46

Status	File	Size
new	private_content.d10.3289146-12.patch	825 bytes
new	private_content.d10.3289146-interdiff-10-12.txt	347 bytes

Comment #13

1 August 2023 at 11:08

AdamPS committed af49841c on 8.x-2.x

Issue #3289146 by AdamPS, joseph.olstad: Drupal 10 compatibility fixes

Comment #14

adamps commented 1 August 2023 at 11:08

Status:

Needs review

» Fixed

Thanks

Comment #15

joseph.olstad

French

commented 1 August 2023 at 13:19

Thanks @AdamPS ! :)

Comment #16

joseph.olstad

French

commented 1 August 2023 at 13:21

@AdamPS , please tag a new release 8.x-2.0 and push it out :)

Thanks :)
If you want, you can assign me as co-maintainer and I can do this for you, however if you can do this for us that'd be great, makes it easier for people to upgrade to D10 if they can just go composer up -W