Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 openapi_ui_swagger.1.x-dev.rector.patch460 bytesproject update bot

Issue fork openapi_ui_swagger-3288876

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new openapi_ui_swagger.1.x-dev.rector.patch460 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Welp, that seems clear.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/openapi_ui_swagger.info.yml
@@ -1,8 +1,7 @@
-core: 8.x
-core_version_requirement: '^8 || ^9'
+core_version_requirement: ^8 || ^9 || ^10

I think this might actually fail tests, because ^8, if I remember correctly, will cause an error if core: 8.x is not present.

I think we should at least add an automated test to prove that this module is installable.

phenaproxima opened merge request !2

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Alright, I'm satisfied with this.

It proves that the module is installable even with the modified constraint. We can't test on D10 yet because openapi itself is not D10 ready, but this module is so thin that I don't foresee any problem.

richgerdes’s picture

richgerdes
he/him
Primary language English
Location New Jersey, USA
commented

Thanks for the hard work!

richgerdes’s picture

richgerdes
he/him
Primary language English
Location New Jersey, USA
commented
Status: Reviewed & tested by the community » Fixed
chandu7929’s picture

chandu7929 commented

@richgerdes I am not able to download this module on drupal10, as this require 'openapi_ui' and that is not yet D10 compatible. Please check https://www.drupal.org/project/openapi_ui/issues/3288874

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

@rich. This is the only module left which require pre/stable release to have a quick verification all features around OpenAPI.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

Now test cases for PHP 8.1 & MySQL 5.7, D10.0 is also passed due to openapi_ui d10 rc release.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

@rich: If there are no restrictions, would you be able to release D10 pre-/stable?

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

One can use composer require 'drupal/openapi_ui_swagger:dev-1.x#e2db6e53' until D10 pre/stable version get released.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major

Thank you, Rich, Adam for having time to maintain this important module.

Hoping for a soft tag release ( pre-release ), to ease testing with Drupal 10.

Testing now with the 1.x-dev development branch under Drupal ~10.0 using the composer

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Major » Critical
loopy1492’s picture

loopy1492 commented

The patch works for us. Looking forward to a release branch for eventual use in Drupal 10.

rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented

Tested the dev version. Good to release.