Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new470 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

nx2611’s picture

Issue summary: View changes
Status: Needs review » Needs work

What worked:

  • Gitpod.io can only test using the 8.x-1.1.
  • I was able to install and enable the module.
  • Enable layout module in Basic node. Add a new block, I can see the dropdown menu as described and I can add a new block.

This is working well for me.

nx2611’s picture

Status: Needs work » Reviewed & tested by the community

The patch works well. Please check earlier comment.

pyrello made their first commit to this issue’s fork.

pyrello’s picture

Version: 8.x-1.x-dev » 2.x-dev

Should be targeting the 2.x branch.

pyrello’s picture

Status: Reviewed & tested by the community » Needs review

Setting back to needs review.

nx2611’s picture

Re-tested this with the same instructions in #4

gitpod.io setup:
Module Version: 2.x
Issue fork: lb_direct_add-3288260
Branch: 3288260-automated-updates-10
Patch: lb_direct_add.1.x-dev.rector.patch
Drupal Versions: 10.1.x & 9.5.x

Both tests works for me.

pyrello’s picture

Status: Needs review » Reviewed & tested by the community

RTBC based on #12.

  • pyrello committed cac140f on 2.x
    Issue #3288260 by pyrello, Project Update Bot, nx2611: Automated Drupal...
pyrello’s picture

Version: 2.x-dev » 8.x-1.x-dev

Setting back to 8.x-1.x to "backport" this.

pyrello’s picture

  • pyrello committed 2a35648 on 8.x-1.x
    Issue #3288260: Automated Drupal 10 compatibility fixes
    
pyrello’s picture

Status: Reviewed & tested by the community » Fixed

Marking as fixed. Thanks for your help, @nx2611!

pyrello’s picture

Version: 8.x-1.x-dev » 2.x-dev
Status: Fixed » Needs work

Working on https://www.drupal.org/project/lb_direct_add/issues/3203657, a few things have come to my attention:

  • The 8.x-1.x branch appears to be compatible with D10.
  • The 2.x branch introduces JS that relies on jquery.once, which is not compatible with D10 and needs to be updated to use the new core once library.
  • The above consideration means that compatibility for 2.x will need to be ^9.2 || ^10.
pyrello’s picture

Status: Needs work » Active
pyrello’s picture

Status: Active » Fixed

I think I'm just going to resolve these issues in https://www.drupal.org/project/lb_direct_add/issues/3203657

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.