Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#16 8.x-1.x-d9-d10-support.patch20.57 KBmatthew.hallsworth
#11 8.x-1.x-drupal-10-working.patch22.05 KBmatthew.hallsworth
#9 8.x-1.x-drupal-10-compatibility.patch22.3 KBmatthew.hallsworth
#8 8.x-1.x-drupal-10-compatibility.patch21.53 KBmatthew.hallsworth
#7 8.x-1.x-drupal-10-compatibility.patch19.9 KBmatthew.hallsworth
#5 jwt.1.x-dev.rector.patch13.97 KBproject update bot
#5 interdiff-last-bot.6663272.txt1.49 KBproject update bot
#4 jwt.1.x-dev.rector.patch13.12 KBproject update bot
#4 interdiff-last-bot.6643710.txt11.63 KBproject update bot
#2 jwt.1.x-dev.rector.patch3.67 KBproject update bot

Issue fork jwt-3288163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new jwt.1.x-dev.rector.patch3.67 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0

Status: Needs review » Needs work

The last submitted patch, 2: jwt.1.x-dev.rector.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

project update bot’s picture

project update bot commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-last-bot.6643710.txt11.63 KB
new jwt.1.x-dev.rector.patch13.12 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6663272.txt1.49 KB
new jwt.1.x-dev.rector.patch13.97 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

matthew.hallsworth’s picture

matthew.hallsworth commented
Issue summary: View changes
StatusFileSize
new 8.x-1.x-drupal-10-compatibility.patch19.9 KB

I've taken the patch from #5 and brought it in line with the requirements of the Upgrade Status module.

- Fixed version numbers on modules
- Fixed the deprecations in the test files
- Fixed deprecations in modules and updated module files

I need a review and a test of this to ensure it's functional. Thanks!

matthew.hallsworth’s picture

matthew.hallsworth commented
StatusFileSize
new 8.x-1.x-drupal-10-compatibility.patch21.53 KB

Actually I made a mistake in the composer.json requirements, this patch is backwards compatible for D9 still so the old version of PHP still applies.

New patch with composer.json fix.

matthew.hallsworth’s picture

matthew.hallsworth commented
StatusFileSize
new 8.x-1.x-drupal-10-compatibility.patch22.3 KB

Fixed more tests to try and get closer to passing D10

matthew.hallsworth’s picture

matthew.hallsworth commented

I'm not really sure why that test is failing, it passes in my local testbed but that's PHP 8.1 and Drupal 9

I'll have to spin up a D10 setup in DDEV and install this patch with core testing and see why it is failing.

matthew.hallsworth’s picture

matthew.hallsworth commented
StatusFileSize
new 8.x-1.x-drupal-10-working.patch22.05 KB

New patch that works in D10. Running tests. Needs review :)

lammensj made their first commit to this issue’s fork.

malks’s picture

malks commented 
+++ b/composer.json
@@ -12,7 +12,7 @@
+    "drupal/core": "^8.7.12 || ^9.0 || ^10.0",

Because D8 relies on Symfony 3 I don't think we can support D8 any longer and probably should remove the `^8.7.12` requirement. For example `Symfony\Contracts\EventDispatcher\Event` does not exist in Symfony 3.

malks’s picture

malks commented 
+++ b/src/Plugin/KeyType/JwtRsKeyType.php
@@ -84,7 +84,9 @@ class JwtRsKeyType extends KeyTypeBase implements KeyPluginFormInterface {
+    if (PHP_VERSION_ID < 80000) {

I think remove this check and mark it as deprecation with a comment is better as it is still supported in PHP8 but is a nop. @deprecated might mean it gets removed at some stage.

malks’s picture

malks commented

@matthew.hallsworth.dpc I think this is mostly fine. As mentioned though in previous comments I don't think this can actually be compatible with D8 any longer as it has a requirement on Symfony 3. Might need maintainers to step in and comment.

matthew.hallsworth’s picture

matthew.hallsworth commented
StatusFileSize
new 8.x-1.x-d9-d10-support.patch20.57 KB

New patch from feedback, thanks @malks for the review :)

- Have removed D8 since the class callouts are not compatible with Symfony 3
- Have removed the conditional check for PHP version, since it's a no-op in PHP 8.x

edyuenyw’s picture

edyuenyw commented
Status: Needs review » Reviewed & tested by the community

@matthew.hallsworth.dpc
Completed a manual test and it is working fine. I was able to create the test keys and able to add it to the JWT Configuration with no issues.

  • pwolanin committed e171e9cd on 8.x-1.x 
    Issue #3288163 by matthew.hallsworth.dpc, Project Update Bot, lammensj:...
pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Fixed

Committing this with the change of removing drupal core requirement from composer.json since the drupal.org composer infra adds it from the .info file

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pwolanin’s picture

pwolanin commented
Parent issue: » #3278159: Drupal 10 roadmap/hitlist (make 2.0 release)