Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#10 3287044-10.patch740 bytesjohne
#7 domain-domain-site-settings.patch744 bytesvints24
#6 domain-domain-site-settings.patch739 bytesvints24
#4 DrupalCheck.txt2.45 KBchandra gowsalya kannan
#4 D10-functionality.png29.9 KBchandra gowsalya kannan
#4 D9-functionality.jpg63.29 KBchandra gowsalya kannan
#4 AfterPatch-UpgradeStatus.jpg16.11 KBchandra gowsalya kannan
#4 Drupal 10 upgrade status _ BeforePatch.jpg58.92 KBchandra gowsalya kannan
#2 domain_site_settings.1.x-dev.rector.patch732 bytesproject update bot

Issue fork domain_site_settings-3287044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new domain_site_settings.1.x-dev.rector.patch732 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
Issue summary: View changes
chandra gowsalya kannan’s picture

chandra gowsalya kannan commented
Issue summary: View changes
StatusFileSize
new Drupal 10 upgrade status _ BeforePatch.jpg58.92 KB
new AfterPatch-UpgradeStatus.jpg16.11 KB
new D9-functionality.jpg63.29 KB
new D10-functionality.png29.9 KB
new DrupalCheck.txt2.45 KB

Tested Patch #2 manually. This module has dependency on domain and domain config. So after installing and making thes two modules compatible with D10, we are good to enable domain_site_settings. The functionality is working fine in D9 and D10.
Screenshot attached for reference.

Testing methods:
1. Tried installing domain_site_settings but due to dependencies it is not installed.
2. Installed domain and domain_config module and made it D10 compatible.
3. Now domain_site_settings module is enabled and patch is applied.
4. Checked its functionality by refering https://www.drupal.org/project/domain_site_settings.
5. Checked in drupal check, where the errors are ignorable
Moving to RTBC !

vints24’s picture

vints24 commented

Compatibility with drupal/domain 2.0.x-dev ;-)

vints24’s picture

vints24 commented
StatusFileSize
new domain-domain-site-settings.patch739 bytes
vints24’s picture

vints24 commented
StatusFileSize
new domain-domain-site-settings.patch744 bytes
fabsgugu’s picture

fabsgugu commented
Priority: Normal » Critical
kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Status: Needs review » Reviewed & tested by the community

We were getting this when trying to install this module with the latest domain v2.0:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/domain_site_settings ^1.4 -> satisfiable by drupal/domain_site_settings[1.4.0, 1.x-dev].
    - drupal/domain_site_settings[1.4.0, ..., 1.x-dev] require drupal/domain ^1.0 -> found drupal/domain[1.0.0-beta1, ..., 1.0.0-beta8] but it conflicts with your root composer.json require (^2.0@beta).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require drupal/domain_site_settings:*" to figure out if any version is installable, or "composer require drupal/domain_site_settings:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

The patch #2 fixed this issue, patch #6 and #7 could not be applied. So RTBC for patch #2.

Also, we have to use the module as the new way this could be achieved in Domain module could break the site config as #3222413: Using Domain Config UI creates *.yml files with duplicate UUIDs..

johne’s picture

johne commented
StatusFileSize
new 3287044-10.patch740 bytes

I re-rolled this patch and it now applies to the latest in dev. However it looks like composer.lock is generated before patches are applied. So, composer.lock will not correctly list changes to the require section of this module. I had to manually edit composer.lock to be able to install 2.x of domain.

richgerdes made their first commit to this issue’s fork.

johne opened merge request !2

johne’s picture

johne commented

Ah, the correct way around this is to use an issue fork that already has the needed changes.

rumenx’s picture

rumenx
Primary language Bulgarian
Location Bulgaria (EU)
commented

@johne Thanks for the warning about 'composer.lock' and the provided fork with the needed changes.

  • JeroenT committed df7d7b0a on 8.x-1.x authored by johne 
    Issue #3287044: Automated Drupal 10 compatibility fixes
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.