Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#9 automateddrupal10compatibilityissues-3286921.patch3.19 KBorkutmuratyilmaz
#2 db_maintenance.2.0.x-dev.rector.patch409 bytesproject update bot

Issue fork db_maintenance-3286921

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new db_maintenance.2.0.x-dev.rector.patch409 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
Issue summary: View changes
prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Issue summary: View changes
Status: Needs review » Needs work

Patch applying successfully to make it compatible with Drupal 10. A few drupal-check errors

------ -------------------------------------------------------------------------------------- 
  Line   db_maintenance.module                                                                 
 ------ -------------------------------------------------------------------------------------- 
  27     Function db_maintenance_help() should return string but return statement is missing.  
 ------ -------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Module/Db/PrefixHandler.php                                                    
 ------ ----------------------------------------------------------------------------------- 
  23     Call to deprecated method tablePrefix() of class Drupal\Core\Database\Connection:  
         in drupal:10.1.0 and is removed from drupal:11.0.0.                                
         Instead, you should just use Connection::getPrefix().                              
 ------ -----------------------------------------------------------------------------------

It would be greatly appreciated if the module maintainers could create a release for Drupal 10 of this module, as it is widely used on many websites and will be advantageous during the upgrade process from Drupal 8 or 9 to 10.

Thank you.

Vishal Choudhary made their first commit to this issue’s fork.

Akshay72’s picture

Akshay72 commented

Akshay72 I have changed version requirements on this issue because of this missing requirement it was conflicting an issue on this module so I have fixed this on 3286921-automated-drupal-10 branch and now it's working fine please review it.

Akshay72 opened merge request !2

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Needs work » Reviewed & tested by the community

Hello all,

I've applied the code on the Merge request !2, as a patch to this module and the module started to be shown on Upgrade Status page, as Local 10-ready.

Best,
Orkut

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
StatusFileSize
new automateddrupal10compatibilityissues-3286921.patch3.19 KB

I'm uploading the content of @Akshay72's MR, in order to use its URL on my composer.json file, until the day the merge is done.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

Any chance for merge?

wstocker’s picture

wstocker commented

Second that on Orkut Murat Yılmaz' comment :)

chucksimply’s picture

chucksimply commented

3rd on #10

cyu’s picture

cyu commented

I'm a maintainer on this module, but haven't had a use for it since Drupal 6 or 7. I'll test out this patch and merge it in today, but it would be great if a developer that is actively using and contributing to this module wanted to jump in as a co-maintainer so that this could get some better attention.

  • 4a7b3799 committed on 2.0.x 
    Issue #3286921 by Akshay72: Drupal 10 compatibility
cyu’s picture

cyu commented
Version: 2.0.x-dev » 3.0.0-rc1
Status: Reviewed & tested by the community » Needs review

There is a 3.0.0-rc1 available now for D10, and after that gets some usage if there are no reported issues we can set a stable release.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Needs review » Reviewed & tested by the community

I've installed 3.0.0-rc1 on Drupal 10.1.6 and it works nice. I'm changing the issues status as RTBC. Thanks for the new version/branch:)

@cYU, if it is okay for everyone, I'd be glad to contribute as a co-maintainer too:)

deekayen’s picture

deekayen commented

Funny how the world is - I don't own the project I started anymore, but I still have access to bring on more helpers.

@Orkut Murat Yılmaz, granted.
@cYu, you have grant rights now, too.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

@deekayen, sorry for the late reply. I'm so glad for the grant. Thank you:)

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

orkut murat yılmaz closed merge request !2