Problem/Motivation

$ dcp-dr upgrade_status:analyze simple_sitemap_extensions
 [notice] Processing /app/web/modules/contrib/simple_sitemap_extensions.

================================================================================
Simple XML Sitemap Extensions,  1.0.3
Scanned on Wed, 06/08/2022 - 14:53

FILE:
web/modules/contrib/simple_sitemap_extensions/src/Plugin/simple_sitemap/UrlGener
ator/ExtendedEntityUrlGenerator.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      248  Call to deprecated function file_create_url(). Deprecated in
                    drupal:9.3.0 and is removed from drupal:10.0.0. Use the     
                    appropriate method on                                       
                    \Drupal\Core\File\FileUrlGeneratorInterface instead.        
--------------------------------------------------------------------------------

FILE: web/modules/contrib/simple_sitemap_extensions

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The 'simple_sitemap_extensions' extension is not installed. 
                    Cannot check deprecated library use.                        
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/simple_sitemap_extensions/simple_sitemap_extensions.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/simple_sitemap_extensions/modules/sse_dynamic_monthly/sse_dy
namic_monthly.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#4 d10-compatibility.patch1.06 KBomkar-pd

Issue fork simple_sitemap_extensions-3284688

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    useernamee created an issue. See original summary.

    reenaraghavan’s picture

    reenaraghavan commented
    Assigned: Unassigned » reenaraghavan
    reenaraghavan’s picture

    reenaraghavan commented
    Assigned: reenaraghavan » Unassigned
    omkar-pd’s picture

    omkar-pd commented
    Status: Active » Needs review
    StatusFileSize
    new d10-compatibility.patch1.06 KB
    libbna’s picture

    libbna commented
    Status: Needs review » Needs work

    Call to deprecated function file_create_url(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use the appropriate method on \Drupal\Core\File\FileUrlGeneratorInterface instead.

    Module is compatible with d10 but found this deprecated code that needs work. Changing the status to NW.

    omkar-pd’s picture

    omkar-pd commented
    Status: Needs work » Needs review

    The deprecated warning mentioned in #5 is already fixed in this issue https://www.drupal.org/project/simple_sitemap_extensions/issues/3299722.

    libbna’s picture

    libbna commented
    Status: Needs review » Reviewed & tested by the community

    Ok. Then it is ready to go in RTBC.

    fago’s picture

    fago
    Primary language German
    Location Vienna
    commented

    • fago committed 87d09cb5 on 1.0.x authored by omkar-pd 
      Issue #3284688 by omkar-pd: Mark as Drupal 10 compatible
    fago’s picture

    fago
    Primary language German
    Location Vienna
    commented
    Status: Reviewed & tested by the community » Fixed

    merged, please test.

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.