When receiving a manual payment, a contributor should be able to set the completed time for the payment.

CommentFileSizeAuthor
#3 commerce-set_manual_payment_completed-3281159-3.patch5.07 KBaerzas
#2 commerce-set_manual_payment_completed-3281159-2.patch5.07 KBaerzas

Issue fork commerce-3281159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Aerzas created an issue. See original summary.

aerzas’s picture

aerzas commented
StatusFileSize
new commerce-set_manual_payment_completed-3281159-2.patch5.07 KB

Here is a patch proposition.

aerzas’s picture

aerzas commented
StatusFileSize
new commerce-set_manual_payment_completed-3281159-3.patch5.07 KB

Functional test timezone fix.

jsacksick’s picture

jsacksick commented
Status: Active » Closed (won't fix)

There is already logic inPayment::presave() that is supposed to be taking care of that already, see:

   if ($state == 'completed' && $original_state != 'completed') {
      if (empty($this->getCompletedTime())) {
        $this->setCompletedTime(\Drupal::time()->getRequestTime());
      }
    }

If the state is updated to completed, the completed time is set to the current time.

aerzas’s picture

aerzas commented
Status: Closed (won't fix) » Needs review

But the logic you describe only allows the request time to be set while the patch exposes the time to the contributor so they can set a date (in the past for example) in the payment receive form. In our case, contributors handle payment receptions once a week while the payment (a bank transfer) may have arrived earlier.

Note that this doesn't break the default mechanism if no date is provided or if the payment is completed programmatically.

Aerzas opened merge request !102

aerzas’s picture

aerzas commented
Version: 8.x-2.x-dev » 3.0.x-dev

I rebased the MR against commerce 3.0.x

jsacksick’s picture

jsacksick commented

I'm generally not against the change, but this is a breaking change, so it can't be committed as is. Any implementation extending the Manual payment gateway would suddenly break, so not really sure how we should be handling this.