PHP 8.0 warning

Deprecated function: Required parameter $form_state follows optional parameter $input in require_once() line 113 of office_hours.elements.inc

Issue fork office_hours-3280670

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

VladimirAus created an issue. See original summary.

VladimirAus opened merge request !12

VladimirAus opened merge request !13

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Active » Needs review
morganlyndel’s picture

morganlyndel commented
Status: Needs review » Reviewed & tested by the community

I tested this patch on a project running core 7.92 and version7.x-1.x-dev of the module, and my deprecation notices are gone.

This patch follows the backward compatibility fixes mentioned in the PHP Watch documentation as well, so it looks good to me.

Marking this as Reviews & tested by the community - thanks!

VladimirAus closed merge request !12

johnv’s picture

johnv
Primary language Dutch
commented
Title: PHP 8.0 compatibility » PHP 8.0 compatibility problem in office_hours.elements.inc
Version: 7.x-1.x-dev » 7.x-1.9
Category: Feature request » Bug report

  • johnv committed a197faa on 7.x-1.x authored by VladimirAus 
    Issue #3280670 by VladimirAus: PHP 8.0 compatibility problem in...
johnv’s picture

johnv
Primary language Dutch
commented
johnv’s picture

johnv
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.