Problem/Motivation

When there are not enough content, the footer will rise to the top.

Steps to reproduce

Open any page, and make it with a little content [one paragraph as an example], and then look to the footer, it will rise to the top.

Proposed resolution

Have the following changes on both vartheme_bs4 and VARTHMEM_BS4_SUBTHEME template.

  • Change min-height: 100vh for the page
  • Change to stick the footer to the bottom
  • Add mb-5 on last div before the footer-wrapper in the page to add spacing before footer
{# Main #}
{% block main %}
  <div role="main" class="main-container {{ container }} js-quickedit-main-content mb-5">
      .....
      .....
      .....
  </div>
{% endblock %}

{% if page.footer %}
  {% block footer %}
    <div class="footer-wrapper">
      <footer class="footer {{ container }}" role="contentinfo">
        {{ page.footer }}
      </footer>
    </div>
  {% endblock %}
{% endif %}

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.7, vartheme_bs4-9.0.15

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Before:

After [With less content]:
After [With less content]

After [with large content]:

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Abdullah Yassin created an issue. See original summary.

Abdullah Yassin’s picture

Issue summary: View changes

Abdullah Yassin’s picture

Abdullah Yassin’s picture

Issue summary: View changes
StatusFileSize
new105.47 KB
Abdullah Yassin’s picture

Assigned: Abdullah Yassin » Unassigned
Status: Active » Needs review
rajab natshah’s picture

Title: Fix footer position bottom when page have a little content » Fix footer position bottom when page have a little content in Vartheme BS4

  • Abdullah Yassin committed b645507 on 9.0.x
    Issue #3280063: Fix footer position bottom when page have a little...
rajab natshah’s picture

Status: Needs review » Needs work

❌ Testing to ensure no regression

Regression issue
I have noticed the following
Footer with last section or element in the page

Needs to have a bit of spacing between the footer and the last section or element in the page.

rajab natshah’s picture

Abdullah Yassin’s picture

StatusFileSize
new276.98 KB

Fix footer spacing:
footer space

Abdullah Yassin’s picture

Status: Needs work » Needs review
Abdullah Yassin’s picture

Status: Needs review » Needs work
Abdullah Yassin’s picture

Status: Needs work » Needs review

alaa jwiehan’s picture

Issue summary: View changes
StatusFileSize
new58.05 KB
alaa jwiehan’s picture

Issue summary: View changes
StatusFileSize
new127.39 KB
alaa jwiehan’s picture

Issue summary: View changes
StatusFileSize
new341.89 KB
alaa jwiehan’s picture

Issue summary: View changes
StatusFileSize
new58.05 KB
alaa jwiehan’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase-9.0.7, +vartheme_bs4-9.0.15
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.7