Problem/Motivation

Make the module compatible with Drupal 10.

Steps to reproduce

Use the module with Drupal 10.

Proposed resolution

Replace drupal_get_path() with \Drupal::service('extension.path.resolver')->getPath(().

Remaining tasks

  • Create MR
  • Review MR
  • Merge MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork gin_login-3278675

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ricovandevin created an issue. See original summary.

ricovandevin opened merge request !11

ricovandevin’s picture

ricovandevin commented
Title: Call to undefined function drupal_get_path() » D10 compatibility | Call to undefined function drupal_get_path()
Status: Active » Needs review
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs review » Needs work
dieterholvoet’s picture

dieterholvoet commented
Title: D10 compatibility | Call to undefined function drupal_get_path() » Drupal 10 compatibility
Category: Bug report » Task
Issue summary: View changes
dieterholvoet’s picture

dieterholvoet commented

Seems like drupal_get_path() is not the only thing that needs to be changed to make the module compatible with Drupal 10. I replaced usages of file_create_url() as well.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs work » Needs review

Ready for review

saschaeggi’s picture

saschaeggi
he/him
commented
Assigned: ricovandevin » Unassigned
dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Reviewed & tested by the community

Tested on a D10 site, all functionality seems to work without warnings/errors.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks Dieter for testing :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.